This repository has been archived by the owner on Nov 27, 2024. It is now read-only.
Resolve test issue #284
Merged
Resolve test issue #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let's see if the new integration setting actually works |
|
ok the Damask integration tests are not running... @mbruns91 |
samwaseda
commented
Apr 25, 2024
| @@ -36,6 +36,7 @@ jobs: | |||
| if: | | |||
| github.event_name == 'push' || | |||
| ( github.event_name == 'pull_request' && contains(github.event.pull_request.labels.*.name, 'integration' )) | |||
|
|
|||
There was a problem hiding this comment.
Really? That's the difference? I'm starting to hate yaml now
There was a problem hiding this comment.
I'm not sure if it is really a yaml issue. I think is more likely the parser reading this file is a bit over-sensitive to newlines and stuff. I guess you need a newline to correctly close the multiline conditional.
There was a problem hiding this comment.
also, I changed the indentation... I don't know, if you used <tab> for indenting or spaces. I use spaces and only after re-indenting, my editor correctly understood what to highlight.
|
I'll then close #283 , @samwaseda . |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I thinks this PR resolves the issue here