Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

atomicrex file names #443

Merged
merged 3 commits into from
Dec 19, 2022
Merged

atomicrex file names #443

merged 3 commits into from
Dec 19, 2022

Conversation

Leimeroth
Copy link
Member

check for / in identifiers

@Leimeroth Leimeroth mentioned this pull request Jun 29, 2022
Closed
@coveralls
Copy link

coveralls commented Jun 29, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 3623805969

  • 0 of 7 (0.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.006%) to 8.823%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pyiron_contrib/atomistics/atomicrex/structure_list.py 0 7 0.0%
Files with Coverage Reduction New Missed Lines %
pyiron_contrib/atomistics/atomicrex/structure_list.py 1 0%
Totals Coverage Status
Change from base Build 3623676357: -0.006%
Covered Lines: 898
Relevant Lines: 10178
💛 - Coveralls

jan-janssen
jan-janssen approved these changes Dec 19, 2022
View reviewed changes
Copy link
Member

@jan-janssen jan-janssen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - I guess we should merge it as is.

@Leimeroth Leimeroth merged commit e4f66bf into main Dec 19, 2022
@delete-merged-branch delete-merged-branch bot deleted the atomicrex-file-names branch December 19, 2022 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jan-janssen jan-janssen jan-janssen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Leimeroth @coveralls @jan-janssen @liamhuber