Option to store/download working directory #637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 4790917639
💛 - Coveralls |
pmrv
reviewed
Apr 24, 2023
| if not job.is_compressed(): | ||
| job.compress() | ||
| self.upload_file( | ||
| os.path.join(job.working_directory, job.job_name + ".tar.bz2"), form |
There was a problem hiding this comment.
pyiron_base has a function that constructs the archive name, best to use it. (I forgot the name right now, but it's in the same module as the compress/decompress functions)
There was a problem hiding this comment.
I had another look and did not find it, actually, the same pattern is used e.g. here
There was a problem hiding this comment.
Ah, sorry that was part of pyiron/pyiron_base#969 which I didn't get around to merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The downloading is not into the right place to reconstruct the full job directory. However, right now also the names etc. are not pyrionic, nothing is stored in the database and such.
Has to be cleared in conversion to a realistic
ArchiveProject.