Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move tests to unit folder #668

Merged
merged 2 commits into from
May 8, 2023
Merged

Move tests to unit folder #668

merged 2 commits into from
May 8, 2023

Conversation

liamhuber
Copy link
Member

Moving files around to comply with the centralized CI pattern of

tests/
 |-- benchmark/
 |-- integration/
 |-- unit/

Here, I just moved them all into unit. I only skimmed them very quickly, but that seemed reasonable. The whole suite only takes 13s to run on my computer, which further supports that none of these need to be in integration.

I also touched up one deprecation error, where protocol.utils.misc was running from inpsect import getargspec. I just updated this to getfullargspec and ignored the additional return values by throwing them to _.

liamhuber added 2 commits May 8, 2023 14:33
Took only a quick peek, but they all look enough like unit tests to me that it's an OK spot (as opposed to integration or benchmark tests)
@coveralls
Copy link

Pull Request Test Coverage Report for Build 4919878412

  • 1 of 2 (50.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 13.684%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pyiron_contrib/protocol/utils/misc.py 1 2 50.0%
Totals Coverage Status
Change from base Build 4919572529: 0.0%
Covered Lines: 1693
Relevant Lines: 12372

💛 - Coveralls

@liamhuber liamhuber merged commit b6a1fb3 into main May 8, 2023
@delete-merged-branch delete-merged-branch bot deleted the move_tests_to_unit_folder branch May 8, 2023 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants