-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a doc example for workflow inputs and outputs #675
Conversation
Don't worry about test failures; github is currently experiencing issues. Updates here |
Pull Request Test Coverage Report for Build 5071767682
💛 - Coveralls |
@samwaseda bump. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have the feeling that the fundamental examples (such as the ones showing how to access output) should be contained within a class and need not import other classes, because a) it makes it easier for the user to read; b) it makes it easier for the developer to keep doc strings up to date. I find it good that there’s this MD example in this doc, but I might prefer to have this new part executable without importing other classes (I presume it’s possible, right?)
Hmm, I like the sentiment. I do think it's fair to import
It's great that you pushed on this! This docstring was actually out of date as (a) now the node libraries are available directly from the workflow, and (b) the default We could also consider moving the "output" example further up so it doesn't depend on the "MD" example, which I like, but then we'd need an example higher up with sufficient complexity to have output worth looking at, which I dislike. At the end of the day I'm inclined to leave it as an addendum to MD, but if you feel strongly then I'm willing to slide it up. |
Also -- and this is tangential and not something I want to address in this PR, but it comes back to our earlier conversation about naming so I wanted to point it out -- the MD node now reads |
Yeah given the close connection between
That would be perfect! |
I'm happier with it now, good suggestions! Lmk if there's any more you think it needs. |
Closes #674