Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is docs and type hints except that now the key under which a channel is stored in an IO collection doesn't need to be that channel's label.
The rationale for this is that workflows should dynamically be creating IO collections with keys like
f"{node.label}_{channel.label}"
, but I don't want them to be altering the underlying channel label. Right nowWorkflow
does this by just making a (dot)dict out of the channel objects, but it would be nice to use the formalIO
class for the collection so we get access to its helper methods and can have consistent typing betweenWorkflow
andNode
for whatinputs
andoutputs
look like.@samwaseda, because this is almost just doc changes, and I want the functional change for us in #729, I'll probably merge it without review. But if you want to take a peek anyhow and leave some comments where anything is unclear/poorly worded, I would be happy to open a patching PR to polish it up.