Order things for circular graphs #761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was necessary to get cyclic workflows to cycle without failing.
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
|
Pull Request Test Coverage Report for Build 5488172209
💛 - Coveralls |
samwaseda
requested changes
Jul 10, 2023
|
The changes are connected |
Co-authored-by: Sam Dareska <[email protected]>
Co-authored-by: Sam Dareska <[email protected]>
Co-authored-by: Sam Dareska <[email protected]>
Agreed, that reads much nicer. All committed. |
samwaseda
approved these changes
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A simple fix to
Function(Node)behaviour such that output channels get updated after the running status gets set to false but before the ran signal fires. This makes it possible to unambiguously resolve race conditions in cyclic graphs.This is important, necessary, and ready for use, but not something I want to be selling yet -- so it gets tested in the integration tests and is documented in the classes, but is intentionally not yet advertised in the demo notebook.