Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

versioneer update to 0.29 #880

Merged
merged 17 commits into from
Oct 6, 2023
Merged

versioneer update to 0.29 #880

merged 17 commits into from
Oct 6, 2023

Conversation

jan-janssen
Copy link
Member

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2023

Binder 👈 Launch a binder notebook on branch pyiron/pyiron_contrib/versioneer_update

@jan-janssen jan-janssen closed this Oct 6, 2023
@jan-janssen jan-janssen reopened this Oct 6, 2023
@jan-janssen
Copy link
Member Author

ImportError                               Traceback (most recent call last)
Cell In[6], line 1
----> 1 from pyiron_contrib.tinybase.executor import ProcessExecutor, BackgroundExecutor, Executor

File ~/work/pyiron_contrib/pyiron_contrib/pyiron_contrib/tinybase/executor.py:292
    288     def submit(self, tasks):
    289         return FuturesExecutionContext(self._client, tasks)
--> 292 from pympipool import PoolExecutor
    295 class PyMPIExecutor(Executor):
    296     def __init__(self, max_workers, **kwargs):

ImportError: cannot import name 'PoolExecutor' from 'pympipool' (/usr/share/miniconda3/envs/my-env/lib/python3.11/site-packages/pympipool/__init__.py)

@jan-janssen
Copy link
Member Author

@pmrv Can you help me out here? tinybase does not find the executable, but I am not exactly sure which executable it is looking for:

---------------------------------------------------------------------------
Exception encountered at "In [57]":
---------------------------------------------------------------------------
ValueError                                Traceback (most recent call last)
Cell In[57], line 1
----> 1 sh.input.command.version = '1.2.4'

File ~/work/pyiron_contrib/pyiron_contrib/pyiron_contrib/tinybase/shell.py:88, in ExecutablePathResolver.version(self, value)
     86     self._version = value
     87 else:
---> 88     raise ValueError(f"Given version '{value}' not in {vers}!")

ValueError: Given version '1.2.4' not in []!

Input Notebook:  notebooks/tinybase/TinyJob.ipynb
Output Notebook: notebooks/tinybase/TinyJob-out.ipynb

Executing:   0%|          | 0/43 [00:00<?, ?cell/s]0.00s - Debugger warning: It seems that frozen modules are being used, which may

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pmrv - I updated the hard coded path here to fix the continuous integration environment. I am not sure how this ever worked in the continuous integration environment. Still it would be better to define the path relative to the notebook.

@jan-janssen jan-janssen merged commit f824de2 into main Oct 6, 2023
@delete-merged-branch delete-merged-branch bot deleted the versioneer_update branch October 6, 2023 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants