Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add generic job factories #896

Merged
merged 4 commits into from
Nov 30, 2023
Merged

Add generic job factories #896

merged 4 commits into from
Nov 30, 2023

Conversation

pmrv
Copy link
Contributor

@pmrv pmrv commented Oct 24, 2023

A JobFactory is a light weight object that represents a certain type of pyiron job. It can be used by abstract workflows to run jobs without knowing what the reference model and the detailed parameters e.g. for the HPC queue are, without having to pass all of this information through all layers of the workflow.

A JobFactory is a light weight object that represents a certain type of
pyiron job.  It can be used by abstract workflows to run jobs without
knowing what the reference model and the detailed parameters e.g. for
the HPC queue are, without having to pass all of this information
through all layers of the workflow.
@pmrv pmrv added the enhancement New feature or request label Oct 24, 2023
@github-actions
Copy link
Contributor

Binder 👈 Launch a binder notebook on branch pyiron/pyiron_contrib/jobs

@pmrv
Copy link
Contributor Author

pmrv commented Oct 24, 2023

This may be a bit cryptic (the example in the docstring might help or it might not), but I use these objects in a lot of my work now and I need them to live somewhere. If this is not wanted in contrib, I can put them up separately.

@coveralls
Copy link

coveralls commented Oct 24, 2023

Pull Request Test Coverage Report for Build 7033608708

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 549 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.2%) to 16.375%

Files with Coverage Reduction New Missed Lines %
atomistics/atomicrex/structure_list.py 43 0.0%
atomistics/atomistics/master/qha.py 46 0.0%
atomistics/atomicrex/potential_factory.py 145 0.0%
atomistics/atomicrex/function_factory.py 315 0.0%
Totals Coverage Status
Change from base Build 6628417645: -0.2%
Covered Lines: 2524
Relevant Lines: 15414

💛 - Coveralls

@pmrv pmrv merged commit fc39da3 into main Nov 30, 2023
@delete-merged-branch delete-merged-branch bot deleted the jobs branch November 30, 2023 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants