-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix symmetry tests #222
Fix symmetry tests #222
Conversation
WalkthroughThe changes in the code involve removing the import statement for Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- tests/test_symmetry.py (1 hunks)
Additional comments not posted (1)
tests/test_symmetry.py (1)
Line range hint
1-13
:
Verify the removal of_SymmetrizeTensor
.Ensure that
_SymmetrizeTensor
was not used in the file. If it was unused, the removal is justified.Verification successful
The removal of
_SymmetrizeTensor
is justified.The
_SymmetrizeTensor
import was not found in the filetests/test_symmetry.py
or anywhere else in the repository, indicating that it was unused.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify if `_SymmetrizeTensor` was used in the file before removal. # Test: Search for `_SymmetrizeTensor` usage. Expect: No usage found. rg '_SymmetrizeTensor' tests/test_symmetry.pyLength of output: 45
Script:
#!/bin/bash # Description: Verify if `_SymmetrizeTensor` is used anywhere in the repository. # Test: Search for `_SymmetrizeTensor` usage in the entire repository. Expect: No usage found. rg '_SymmetrizeTensor'Length of output: 22
Tools
Ruff
20-20:
spglib
imported but unused; consider usingimportlib.util.find_spec
to test for availability(F401)
@samwaseda I found the issue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah good job
Summary by CodeRabbit