Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request]: Make global correction parameter max_iter more clear #411

Closed
JoschD opened this issue Mar 17, 2023 · 1 comment
Closed

[Feature Request]: Make global correction parameter max_iter more clear #411

JoschD opened this issue Mar 17, 2023 · 1 comment
Assignees
@JoschD
Labels
Priority: Low Work on this if you have some spare time. Type: Feature A (suggetion for a) new feature or enhancement in functionality. Type: Question Something is not clear or is not understood.

Comments

@JoschD
Copy link
Member

JoschD commented Mar 17, 2023 •
edited
Loading

Feature Description

A the moment max_iter gives the numbers of re-iterations for the global corrections. That means a value of 0 is zero re-iterations and one correction iteration. This is very confusing.

Possible Implementation

IMHO it should be renamed to iterations and 1 means single iteration corrections, while everything above means more iteration steps.

If we don't change it now (while I am also implementing the connection to the GUI), we will never change it. Any objections?
@lmalina @awegsche @fsoubelet @Mael-Le-Garrec ?
@JoschD JoschD added the Type: Feature A (suggetion for a) new feature or enhancement in functionality. label Mar 17, 2023
@JoschD JoschD self-assigned this Mar 17, 2023
@JoschD JoschD added Type: Question Something is not clear or is not understood. Priority: Low Work on this if you have some spare time. labels Mar 17, 2023
@JoschD
Copy link
Member Author

JoschD commented Jun 9, 2023

Fixed in #413

@JoschD JoschD closed this as completed Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoschD JoschD

Labels
Priority: Low Work on this if you have some spare time. Type: Feature A (suggetion for a) new feature or enhancement in functionality. Type: Question Something is not clear or is not understood.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JoschD