Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check Corrections #413

Merged
merged 52 commits into from
May 22, 2023
Merged

Check Corrections #413

merged 52 commits into from
May 22, 2023

Conversation

JoschD
Copy link
Member

@JoschD JoschD commented Apr 20, 2023

Implements the feature of checking corrections and their influence on the optics via MAD-X and plotting the expected results.

@JoschD
Copy link
Member Author

JoschD commented May 13, 2023

I apologize for the length of this PR...
There is no version bump yet, as I want to do the release later, when the GUI itself is ready.

omc3/check_corrections.py Outdated Show resolved Hide resolved
omc3/check_corrections.py Outdated Show resolved Hide resolved
omc3/correction/filters.py Show resolved Hide resolved
omc3/correction/utils_check.py Outdated Show resolved Hide resolved
omc3/global_correction.py Show resolved Hide resolved
omc3/model/accelerators/lhc.py Show resolved Hide resolved
omc3/utils/iotools.py Show resolved Hide resolved
tests/accuracy/test_global_correction.py Outdated Show resolved Hide resolved
@fsoubelet
Copy link
Member

fsoubelet commented May 13, 2023

Unrelated but since I saw some ArrayLike instances in there and it relates to #407, I have found the fix for their expansion in the doc pages. It is solved by adding the following in our doc/conf.py:

# This is to tell Sphinx how to print some specific type annotations
# See: https://stackoverflow.com/a/67483317
# See: https://www.sphinx-doc.org/en/master/usage/extensions/autodoc.html#confval-autodoc_type_aliases
autodoc_type_aliases = {"ArrayLike": "ArrayLike"}

This way they will appear as literally ArrayLike in the documentation.

omc3/utils/iotools.py Outdated Show resolved Hide resolved
@JoschD JoschD requested review from alejandroborj and fsoubelet May 15, 2023 09:38
alejandroborj
alejandroborj previously approved these changes May 15, 2023
Copy link
Member

@fsoubelet fsoubelet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know I'm annoying, but you love it.

omc3/check_corrections.py Outdated Show resolved Hide resolved
omc3/check_corrections.py Show resolved Hide resolved
omc3/check_corrections.py Outdated Show resolved Hide resolved
omc3/check_corrections.py Outdated Show resolved Hide resolved
omc3/check_corrections.py Outdated Show resolved Hide resolved
omc3/check_corrections.py Outdated Show resolved Hide resolved
omc3/check_corrections.py Outdated Show resolved Hide resolved
omc3/check_corrections.py Show resolved Hide resolved
@codeclimate
Copy link

codeclimate bot commented May 22, 2023

Code Climate has analyzed commit 46fe2f0 and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 1

The test coverage on the diff in this pull request is 93.2% (50% is the threshold).

This pull request will bring the total coverage in the repository to 85.9% (0.5% change).

View more on Code Climate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature A (suggetion for a) new feature or enhancement in functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants