-
-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Find frozen stdlib modules #1513
Conversation
Pull Request Test Coverage Report for Build 2207138448
💛 - Coveralls |
99ebcfb
to
e2cb028
Compare
Turns out this fixes all other outstanding issues with I do wonder why the test suite is so incredibly slow though. Is that an issue with us? Or is |
Locally, with 2.10s call tests/unittest_nodes.py::ImportNodeTest::test_from_self_resolve
1.34s call tests/unittest_brain.py::SixBrainTest::test_attribute_access
1.25s call tests/unittest_brain.py::ModuleExtenderTest::test_extension_modules
0.70s call tests/unittest_manager.py::AstroidManagerTest::test_ast_from_class
0.61s call tests/unittest_scoped_nodes.py::ClassNodeTest::test_mro_typing_extensions
0.55s call tests/unittest_builder.py::BuilderTest::test_inspect_build0
0.46s call tests/unittest_manager.py::AstroidManagerTest::test_ast_from_class_with_module
0.42s call tests/unittest_builder.py::BuilderTest::test_inspect_build_type_object
0.38s call tests/unittest_brain.py::CollectionsDequeTests::test_deque
0.31s call tests/unittest_brain.py::ReBrainTest::test_re_pattern_subscriptable
0.29s call tests/unittest_inference.py::InferenceTest::test_unary_operands
0.29s call tests/unittest_scoped_nodes.py::ModuleNodeTest::test_stream_api
0.28s call tests/unittest_scoped_nodes.py::ClassNodeTest::test_has_dynamic_getattr
0.26s call tests/unittest_brain.py::DateutilBrainTest::test_parser
0.24s call tests/unittest_brain.py::TypingBrain::test_callable_type
0.24s call tests/unittest_nodes.py::ImportNodeTest::test_bad_import_inference
0.24s call tests/unittest_brain.py::MultiprocessingBrainTest::test_multiprocessing_manager
0.23s call tests/unittest_brain.py::AttrsTest::test_attr_transform
0.21s call tests/unittest_builder.py::test_module_build_dunder_file
0.19s call tests/unittest_brain.py::SubprocessTest::test_popen_does_not_have_class_getitem With 1.83s call tests/unittest_nodes.py::ImportNodeTest::test_from_self_resolve
1.33s call tests/unittest_brain.py::ModuleExtenderTest::test_extension_modules
0.67s call tests/unittest_brain.py::test_http_client_brain
0.59s call tests/unittest_scoped_nodes.py::ClassNodeTest::test_mro_typing_extensions
0.58s call tests/unittest_builder.py::BuilderTest::test_inspect_build_type_object
0.55s call tests/unittest_manager.py::AstroidManagerTest::test_ast_from_class_with_module
0.47s call tests/unittest_builder.py::BuilderTest::test_inspect_build0
0.34s call tests/unittest_manager.py::AstroidManagerTest::test_ast_from_class
0.33s call tests/unittest_brain.py::CollectionsDequeTests::test_deque
0.32s call tests/unittest_scoped_nodes.py::ModuleNodeTest::test_without_docstring
0.32s call tests/unittest_brain.py::TypingBrain::test_callable_type
0.29s call tests/unittest_brain.py::AttrsTest::test_attr_transform
0.25s call tests/unittest_brain.py::ReBrainTest::test_regex_flags
0.23s call tests/unittest_scoped_nodes.py::ClassNodeTest::test_has_dynamic_getattr
0.21s call tests/unittest_brain.py::MultiprocessingBrainTest::test_multiprocessing_manager
0.21s call tests/unittest_inference.py::InferenceTest::test_no_infinite_ancestor_loop
0.19s call tests/unittest_nodes.py::ImportNodeTest::test_bad_import_inference
0.17s call tests/unittest_brain.py::ReBrainTest::test_re_pattern_subscriptable
0.17s call tests/unittest_builder.py::test_module_build_dunder_file
0.16s call tests/unittest_inference.py::InferenceTest::test_two_parents_from_same_module So, possible something to do with the runner/GA? |
I got some data in DanielNoord#20. Not immediately sure what is causing this. But since |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! A very elegant solution. Thank you @DanielNoord 🐬
One part was the cache which didn't got stored until you fixed all the issues. That's already (1:30min). |
@cdce8p DanielNoord#20 shows significant differences in test times though. |
It could be 🤷🏻♂️ Caching not so much, but optimizations during install are a possibility. Especially if that time difference doesn't happen locally. I only noticed the different log output. |
Steps
Description
Closes #1512.
Related is python/cpython#65935. I'm not sure how to test this on
3.10
though as this is a new feature on3.11
. That would be the next step.Type of Changes
Related Issue