-
-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various TryStar
fixes
#2142
Various TryStar
fixes
#2142
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## maintenance/2.15.x #2142 +/- ##
=====================================================
Coverage ? 92.84%
=====================================================
Files ? 95
Lines ? 11089
Branches ? 0
=====================================================
Hits ? 10296
Misses ? 793
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you ! How did you find out that this was required ? Is this just your general knowledge of what's required in astroid ?
I was looking at #1867 and noticed that |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-maintenance/2.15.x maintenance/2.15.x
# Navigate to the new working tree
cd .worktrees/backport-maintenance/2.15.x
# Create a new branch
git switch --create backport-2142-to-maintenance/2.15.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 73482936a4eabeb3e51425f3b5c56d1d9e0a9bb9
# Push it to GitHub
git push --set-upstream origin backport-2142-to-maintenance/2.15.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-maintenance/2.15.x Then, create a pull request where the |
Seems like targeted the wrong branch though 😞 |
Did you want to fix 2.15.4 ? I think it's targeted in the right branch but there was a conflict during the cherry-pick so it needs to be applied manually ? |
The fix should be in both |
Ha, right ! Yes, let's release 2.15.4 directly then. |
Thank you for releasing so fast, Marc 🚀 ! |
Description
TryStar
nodes.TryStar
toALL_NODE_CLASSES
and__all__