Adjust where tests are located #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 286
💛 - Coveralls |
4 similar comments
Pull Request Test Coverage Report for Build 286
💛 - Coveralls |
Pull Request Test Coverage Report for Build 286
💛 - Coveralls |
Pull Request Test Coverage Report for Build 286
💛 - Coveralls |
Pull Request Test Coverage Report for Build 286
💛 - Coveralls |
Pull Request Test Coverage Report for Build 290
💛 - Coveralls |
atodorov
force-pushed
the
tests_under_pylint-django
branch
from
94b6ec5 to
c19ad20
Compare
|
@atodorov looks great. Thanks a lot for those modifications. The only thing that is missing is the modification of |
|
👍 from me too |
- setup.py: move all the values directly as parameters to setup() to make it more readable and avoid scrolling back and forth to figure out what comes from where - MANIFEST.in: add Markdown files to the list of included files, e.g. CHANGELOG, CONTRIBUTORS, README; adjust how we include the supplementary files for tests
atodorov
force-pushed
the
tests_under_pylint-django
branch
from
c19ad20 to
98e5091
Compare
|
@aerostitch fixed FYI I will do a quick fix for #96 as well and probably release the new version tomorrow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@moubctez, @aerostitch,
I think this PR takes care of the test directory not being directly installed under
site-packages/while still carrying all test related files in the tarball to accommodate Debian packaging.Let me know if you see anything I'm missing here. I can release 0.9.2 without further if the proposed changes work for you.