New linter: warn about missing backwards migrations #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1111
💛 - Coveralls |
|
@brymut also rebase to the latest master which fixed the issue with failing tests in CI |
brymut
force-pushed
the
add-backwards-migration-checker
branch
2 times, most recently
from
b961b4f to
fd814a5
Compare
atodorov
suggested changes
Jul 9, 2020
brymut
force-pushed
the
add-backwards-migration-checker
branch
from
fd814a5 to
5bfb3db
Compare
|
@atodorov may I please get some help, I can't seem to be able to get the test to recognise the |
brymut
force-pushed
the
add-backwards-migration-checker
branch
2 times, most recently
from
f82c3d8 to
aeac67b
Compare
atodorov
suggested changes
Jul 10, 2020
pylint_django/tests/input/migrations/0003_without_backwards.txt
Outdated
Show resolved
Hide resolved
brymut
force-pushed
the
add-backwards-migration-checker
branch
2 times, most recently
from
d1e011d to
8a5a42b
Compare
brymut
force-pushed
the
add-backwards-migration-checker
branch
from
8a5a42b to
dd61a73
Compare
brymut
force-pushed
the
add-backwards-migration-checker
branch
from
dd61a73 to
2b6dbd7
Compare
atodorov
approved these changes
Jul 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs kiwitcms/Kiwi#1774 New linter: warn about missing backwards migrations.
@atodorov, not quite sure how to handle/structure the testing for this. Should I add migrations to test with on top of the tests for the db_performance checker or should I have it with the other checkers? As it looks like the db_performance is added on separately to add the migrations path?