Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Per dir config #1988

Closed
wants to merge 57 commits into from
Closed

Per dir config #1988

wants to merge 57 commits into from

Conversation

hippo91
Copy link
Contributor

@hippo91 hippo91 commented Apr 1, 2018

Partial work on reintegrating man page generation. #1887.

@AWhetter the work is not finish, but i wanted to have your opinion before finishing it.
I can't reproduce exactly the historical man page because i'm unable to retrieve sectionsMASTER, EXCEPTIONS, LOGGING ... Instead most of the options are now under OPTIONAL ARGUMENTS section. Are you ok with this?
Moreover i think there are problems with some options like --lists-msgs which is now waiting for an argument.
The CI is failing but i don't suppose it's due to this work.

AWhetter and others added 30 commits July 9, 2017 23:37
@AWhetter
expand_files returns a ModuleDescription instead of a dict
1d623d1
@AWhetter
Moved expand_files to utils
1cbe43c
@AWhetter
Moved parallel code outside of PyLinter
aa61b46
@AWhetter
expand_files returns a ModuleDescription instead of a dict
7f3a3f5
@AWhetter
Moved expand_files to utils
9d68129
@AWhetter
Moved parallel code outside of PyLinter
e592300
@AWhetter
Split up find_pylintrc
d5592db 
Also added unused method for finding a nearby pylintrc for when
we turn on per directory configs.
@AWhetter
Slotted in IniFileParser and Configuration
7b445d8
@AWhetter
Slotted in argparse with CLIParser
3191fe3
@AWhetter
Implemented long help with argparse
f410912
@AWhetter
Fixed callback options needing to take an argument
ba6f27a
@AWhetter
Fixed option callbacks not getting run
6421ad1
@AWhetter
Finished removing optparse
85c02ca
@AWhetter
Fixed Python2 syntax errors
aed928e
@AWhetter
Moved walk_up to utils
45f774b
@AWhetter
Started using more specific exceptions in config
7df26f9
@AWhetter
Fixed up docstrings
07e4d08
@hippo91
Merge remote-tracking branch 'upstream/per_dir_config' into per_dir_c…
4b061ff 
…onfig
@hippo91
Add of _ManHelpFormatter class and beginning of generate_manpage coding.
cfd7210
@AWhetter
expand_files returns a ModuleDescription instead of a dict
1df99a7
@AWhetter
Moved expand_files to utils
97adbec
@AWhetter
Moved parallel code outside of PyLinter
a2ce483
@AWhetter
Split up find_pylintrc
177166e 
Also added unused method for finding a nearby pylintrc for when
we turn on per directory configs.
@AWhetter
Slotted in IniFileParser and Configuration
0513e1f
@AWhetter
Slotted in argparse with CLIParser
7160a33
@AWhetter
Implemented long help with argparse
6ec48bc
@AWhetter
Fixed callback options needing to take an argument
758e356
@AWhetter
Fixed option callbacks not getting run
e0bbefa
@AWhetter
Finished removing optparse
6e5bb56
@AWhetter
Fixed Python2 syntax errors
a9320e6
@AWhetter
Copy link
Contributor

Sorry it's taken me so long to look at this.
The branch is already failing the tests so don't worry about those for now. There's a task open to get them fixed.
I'm not sure why so many arguments are under OPTIONAL ARGUMENTS. We should fix that, but I'm happy for us to do it in another pull request.
I didn't know about the --list-msgs problem. I've created a task for this: https://github.com/PyCQA/pylint/projects/1#card-9018104

@PCManticore PCManticore added the Needs review 🔍 Needs to be reviewed by one or multiple more persons label May 7, 2018
@PCManticore PCManticore requested a review from AWhetter May 14, 2018 14:50
@PCManticore PCManticore added reviewed-waiting-updates and removed Needs review 🔍 Needs to be reviewed by one or multiple more persons labels May 14, 2018
@PCManticore PCManticore mentioned this pull request May 14, 2018
Closed
@AWhetter AWhetter force-pushed the per_dir_config branch 2 times, most recently from ef40ae7 to 3048d07 Compare May 17, 2018 16:13
@PCManticore
Copy link
Contributor

Hey @hippo91 and @AWhetter what's the status of this PR?

@hippo91
Copy link
Contributor Author

hippo91 commented Jul 15, 2018

@PCManticore i'm really sorry but i had not enough time to work on this since i made this PR.
There is still a lot of work to do but i'm unable to handle this at this moment.

@PCManticore
Copy link
Contributor

No worries @hippo91 I was just being curious where things were at! Don't worry, feel free to pick this up whenever you have time!

@pinealan
Copy link
Contributor

pinealan commented Jan 11, 2019 •
edited
Loading

Apologies in advance to hijack this PR for a second. I was working on a branch to integrate pyproject.toml and possibly setup.cfg #617. As I went down the rabbit hole it became obvious that the whole config system had to be refactored to enable that. I had a bit of work done on that but luckily I just caught this thread since it would definitely be duplicate work.

Now the question is the status of this PR. If @AWhetter and @hippo91 are still busy at the moment I don't mind helping out and try to first finish up this PR before working on a new PR for those new config file formats.

@AWhetter
Copy link
Contributor

AWhetter commented Jan 11, 2019 •
edited
Loading

Hi @pinealan. If you want to take over this PR, please do! Unfortunately I have not found much time to finish it myself this past few months.
This PR alone doesn't refactor the configuration system. It's part of a bigger project (https://github.com/PyCQA/pylint/projects/1) for #618. That project page lists what work is left to do. It's also been a while since the branch has been worked on. It needs rebasing on top of master and formatting with black also, but feel free to work off of the branch in it's current state if you prefer.
Any help you can give would be greatly appreciated!

@hippo91
Copy link
Contributor Author

hippo91 commented Jan 12, 2019

@pinealan thank you for your message.
I'm in the same situation as @AWhetter . If you want to work on this PR you'are welcome and i'll be pleased to help you as much as i can!

@pinealan
Copy link
Contributor

I've looked at both branches under PyCAQ and hippo. Given that they're fairly out of sync and both would need to rebase on master, I will make a new branch and cherry pick what's necessary. When I've wrapped my head around everything I'll open a new PR for overall refactoring of config. Hopefully that'll cover this PR and tidy things up.

@hippo91
Copy link
Contributor Author

hippo91 commented Jan 26, 2019

Thank you @pinealan!

@AWhetter
Copy link
Contributor

AWhetter commented Feb 9, 2019

@pinealan If you still wanted to continue the work on this, the branch is now rebased on top of master.

@hippo91 I'm going to close this PR because it's very out of date with the current branch. But feel free to pick this up again if you want to.

@AWhetter AWhetter closed this Feb 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AWhetter AWhetter Awaiting requested review from AWhetter

Assignees
No one assigned
Labels
Work in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hippo91 @AWhetter @PCManticore @pinealan @fffergal