Allow linting directories without __init__.py
#3569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was a regressin in 2.5. Close #3528
2 similar comments
Pierre-Sassoulas
approved these changes
May 2, 2020
There was a problem hiding this comment.
pip3 install .;python3 pylint/__main__.py module
Processing /home/pierre/PycharmProjects/pylint
Collecting astroid<=2.5,>=2.4.0 (from pylint==2.5.0)
Using cached https://files.pythonhosted.org/packages/7c/f6/880bade8329525fd9aa9051891b4b8fe2e52c7aab7412443f8743028a590/astroid-2.4.0-py3-none-any.whl
Requirement already satisfied: isort<5,>=4.2.5 in ./venv/lib/python3.6/site-packages (from pylint==2.5.0)
Requirement already satisfied: mccabe<0.7,>=0.6 in ./venv/lib/python3.6/site-packages (from pylint==2.5.0)
Requirement already satisfied: toml>=0.7.1 in ./venv/lib/python3.6/site-packages (from pylint==2.5.0)
Requirement already satisfied: typed-ast<1.5,>=1.4.0; implementation_name == "cpython" and python_version < "3.8" in ./venv/lib/python3.6/site-packages (from astroid<=2.5,>=2.4.0->pylint==2.5.0)
Requirement already satisfied: lazy-object-proxy==1.4.* in ./venv/lib/python3.6/site-packages (from astroid<=2.5,>=2.4.0->pylint==2.5.0)
Requirement already satisfied: wrapt~=1.11 in ./venv/lib/python3.6/site-packages (from astroid<=2.5,>=2.4.0->pylint==2.5.0)
Requirement already satisfied: six~=1.12 in ./venv/lib/python3.6/site-packages (from astroid<=2.5,>=2.4.0->pylint==2.5.0)
Installing collected packages: astroid, pylint
Found existing installation: astroid 2.3.3
Uninstalling astroid-2.3.3:
Successfully uninstalled astroid-2.3.3
Found existing installation: pylint 2.4.4
Uninstalling pylint-2.4.4:
Successfully uninstalled pylint-2.4.4
Running setup.py install for pylint ... done
Successfully installed astroid-2.4.0 pylint-2.5.0
--------------------------------------------------------------------
Your code has been rated at 10.00/10 (previous run: 10.00/10, +0.00)
And damn, it was simpler to fix than I thought :D Could the base problem with "pylint ." not working be fixed in a similar "simple" manner?
|
Not sure about |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This was a regression in 2.5 caused by a6d7ffc.
Close #3528
Type of Changes