Create new error arguments-renamed #4467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commits creates the new error arguments-renamed based on the functionality added on pylint-dev#4422 and the changes of pylint-dev#4456.
This commit merges the two kinds of test files that existed for the arguments-differ error, since now all tests run in Python3.
for more information, see https://pre-commit.ci
|
@Pierre-Sassoulas what do you think about this? :) |
Pierre-Sassoulas
requested changes
May 15, 2021
There was a problem hiding this comment.
Looks good, thanks. Lots of test added, very few changes, I like that :) ! I just have a small remark to reduce duplication. Maybe you want to take a look too @cdce8p ?
@Pierre-Sassoulas I have only briefly looked at it. I don't think it will add any errors so it should be ok once the review process is done. |
Pierre-Sassoulas
approved these changes
May 17, 2021
|
My pleasure! I'm glad I helped :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps
doc/whatsnew/<current release.rst>.Description
This pull request creates a new error called
arguments-renamed, which identifies any changes in theparameter names of overridden functions. It separates the functionality of
arguments-differ.Based on additions of #4422 and #4456
It also merges the two kinds of test files (Py3- and Py3+) that existed for
arguments-differin one.Type of Changes
Related Issue
Part two and closes #3536