-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Type add_message
and add MessageLocationTuple
#5050
Type add_message
and add MessageLocationTuple
#5050
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this change. But maybe the msgid/symbol typing is something that should be done prior to this one ?
Co-authored-by: Pierre Sassoulas <[email protected]>
Co-authored-by: Marc Mueller <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. @Pierre-Sassoulas Would you mind taking another look?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, you're almost single-handedly typing pylint :)
Type of Changes
Description
This adds typing to
add_message
and adds a newNamedTuple
totyping.py
. I add a deprecation warning forMessage
, but I'm not sure if it is even necessary. IsMessage
part of the public API? If not I can remove it.The
type: ignore
intests/testutils/test_output_line.py
will be fixed in a follow-up PR.OutputLine
needs a little refactor to only acceptint
forcolumn
andline
. This will bring it in line with all other code that referencescolumn
orline
, where those are alsoint
.