-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Normalize input of ignore-paths
for all path types
#5201
Conversation
Pull Request Test Coverage Report for Build 1376349524
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job normalizing this aspect, this is often used in option and using the same mechanism all the time will save us from bugs and duplication.
Co-authored-by: Pierre Sassoulas <[email protected]>
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice cleanup !
doc/whatsnew/<current release.rst>
.Type of Changes
Description
This normalises the input to the
ignore-paths
config option by creating both a Posix and Windows path from the provided regex pattern.It does so by adding a new validator called
_regexp_paths_csv_validator
which creates a list ofpath regex
s.Furthermore, it adds a new overload to
get_global_option
forList[Pattern[str]]
return types, as we did not have that yet.Closes #5194