Migrate test for extension to functional tests

[Pierre-Sassoulas]

Type of Changes

	Type
✓	🔨 Refactoring

Description

Migrate all the extensions tests that are reading files to the functional tests that permits to test more and are easier to understand.

Refactor prior to #5369

[coveralls]

Pull Request Test Coverage Report for Build 1493913021

• 0 of 0 changed or added relevant lines in 0 files are covered.
• 1 unchanged line in 1 file lost coverage.
• Overall coverage increased (+0.007%) to 93.453%

---

Files with Coverage Reduction	New Missed Lines	%
pylint/extensions/mccabe.py	1	99.05%

Totals
Change from base Build 1492327926:	0.007%
Covered Lines:	13932
Relevant Lines:	14908

---

💛 - Coveralls

[DanielNoord]

Just FYI: This should also block #5349!

[cdce8p]

I'll leave that one up to you. It's definitely an improvement. (Just difficult to review the change.)

[DanielNoord]

Yeah quite difficult to review this. I'm leaning to trusting you on this one, it's just tests anyway so no real danger of breaking things immediately.

[Pierre-Sassoulas]

Thank you for your trust 😄 But to explain better : As we did not change pylint's code the functional test are simply solidifying the current behavior of the code. The tests I removed were opening the file from tests/extension/data and asserting less than what the functional are asserting now. Two other files that appear as "removed" are actually one that I merged together (overlapping_exceptions). I checked that there was an actual output produced by the right expansion. If there is an issue in those it was preexisting. there are still some unittests for extansions in tests/extension.

[cdce8p]

Just noticed something. We do have the tests/functional/ext folder. Maybe that would be a better place as it was meant for extensions.

[Pierre-Sassoulas]

Maybe that would be a better place as it was meant for extensions.

Done, alongside some renaming, directory representing the name of the plugin creation and some name cleanup.