Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify validation of functional test option files #5510

Merged
merged 2 commits into from
Dec 13, 2021
Merged

Unify validation of functional test option files #5510

merged 2 commits into from
Dec 13, 2021

Conversation

DanielNoord
Copy link
Collaborator

  • Add yourself to CONTRIBUTORS if you are a new contributor.
  • Write a good description on what the PR does.

Type of Changes

Type
✓ 🔨 Refactoring

Description

Follow up to #5418 which improves the validation of functional test option files and makes it in line with the other validators.

@DanielNoord DanielNoord added the Maintenance Discussion or action around maintaining pylint or the dev workflow label Dec 13, 2021
Pierre-Sassoulas
Pierre-Sassoulas approved these changes Dec 13, 2021
View reviewed changes
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice !

@Pierre-Sassoulas Pierre-Sassoulas added this to the 2.13.0 milestone Dec 13, 2021
@coveralls
Copy link

coveralls commented Dec 13, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 1572917551

  • 4 of 4 (100.0%) changed or added relevant lines in 2 files are covered.
  • 9 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.01%) to 93.654%
Files with Coverage Reduction New Missed Lines %
pylint/testutils/lint_module_test.py 1 85.63%
pylint/testutils/decorator.py 8 71.43%
Totals Coverage Status
Change from base Build 1572737221: 0.01%
Covered Lines: 14183
Relevant Lines: 15144
💛 - Coveralls

@DanielNoord DanielNoord merged commit 736c0be into pylint-dev:main Dec 13, 2021
@DanielNoord DanielNoord deleted the follow-up-5418 branch December 13, 2021 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pierre-Sassoulas Pierre-Sassoulas Pierre-Sassoulas approved these changes

Assignees
No one assigned
Labels
Maintenance Discussion or action around maintaining pylint or the dev workflow
Projects
None yet
Milestone
2.13.0
Development

Successfully merging this pull request may close these issues.
3 participants
@DanielNoord @coveralls @Pierre-Sassoulas