Fix assignment-from-none false negative case using list.sort() #5738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pierre-Sassoulas
requested changes
Jan 28, 2022
Pierre-Sassoulas
added
the
False Negative 🦋
|
@Pierre-Sassoulas Thanks for the quick review! Will clear the pipeline errors and apply your suggestions. |
orSolocate
force-pushed
the
orb_assign_sort_list
branch
from
d1a786b to
1a8d787
Compare
Pull Request Test Coverage Report for Build 1782765241
💛 - Coveralls |
DanielNoord
requested changes
Jan 29, 2022
There was a problem hiding this comment.
Thanks @orSolocate! Another great addition. Just some comments about style and order. Fix itself is quite elegant 😄
orSolocate
force-pushed
the
orb_assign_sort_list
branch
from
1a8d787 to
7429c46
Compare
Pierre-Sassoulas
approved these changes
Feb 1, 2022
| self.add_message("assignment-from-no-return", node=node) | ||
| else: | ||
| for rnode in returns: | ||
| for ret_node in return_nodes: |
There was a problem hiding this comment.
We could even rename it to return_node, I don't suggest because an IDE refactor should do it instantly.
There was a problem hiding this comment.
You added it yourself already while merging?
There was a problem hiding this comment.
It wasn't that important, so I merged :)
DanielNoord
approved these changes
Feb 2, 2022
This was referenced Jul 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Fix
assignment-from-nonefalse negative case usinglist.sort()Closes #5722