Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release branch 2.13.9 #6563

Merged
merged 8 commits into from
May 13, 2022
Merged

Release branch 2.13.9 #6563

merged 8 commits into from
May 13, 2022

Conversation

Pierre-Sassoulas
Copy link
Member

Blocked by #6528

@Pierre-Sassoulas Pierre-Sassoulas added Blocked 🚧 Blocked by a particular issue Maintenance Discussion or action around maintaining pylint or the dev workflow labels May 9, 2022
@Pierre-Sassoulas Pierre-Sassoulas added this to the 2.13.9 milestone May 9, 2022
@Pierre-Sassoulas Pierre-Sassoulas changed the base branch from main to maintenance/2.13.x May 9, 2022 19:22
@jacobtylerwalls
Copy link
Member

jacobtylerwalls commented May 9, 2022 •
edited
Loading

I think this needs astroid 2.11.5 also.

@Pierre-Sassoulas Pierre-Sassoulas force-pushed the release-branch-2.13.9 branch from f48f187 to 5ec6699 Compare May 9, 2022 20:40
@Pierre-Sassoulas Pierre-Sassoulas mentioned this pull request May 10, 2022
Closed
15 tasks
jacobtylerwalls
jacobtylerwalls reviewed May 11, 2022
View reviewed changes
@Pierre-Sassoulas Pierre-Sassoulas force-pushed the release-branch-2.13.9 branch from 5ec6699 to ad8dcf6 Compare May 11, 2022 14:23
@Pierre-Sassoulas Pierre-Sassoulas removed the Blocked 🚧 Blocked by a particular issue label May 13, 2022
@Pierre-Sassoulas Pierre-Sassoulas force-pushed the release-branch-2.13.9 branch from ad8dcf6 to 24eb140 Compare May 13, 2022 07:01
@matusvalo @Pierre-Sassoulas @DanielNoord
Respect ignore configuration options when --recursive=y. (#6528)
42c0ad5 
* Ignore specified files/directories in recursive mode

Co-authored-by: Pierre Sassoulas <[email protected]>
Co-authored-by: Daniël van Noord <[email protected]>
@Pierre-Sassoulas Pierre-Sassoulas force-pushed the release-branch-2.13.9 branch from 24eb140 to acfe359 Compare May 13, 2022 07:20
@Pierre-Sassoulas Pierre-Sassoulas mentioned this pull request May 13, 2022
Merged
DanielNoord
DanielNoord reviewed May 13, 2022
View reviewed changes
pylint/lint/pylinter.py Outdated

if _is_ignored_file(
root,
self.config.ignore,
Copy link
Collaborator

@DanielNoord DanielNoord May 13, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ref. #6528 (comment)

This seems to work right @Pierre-Sassoulas?

On 2.13.x all config is still stored on the BaseChecker itself. Since PyLinter is a checker you can access it's options with self.config. If you need options from another checker you can do get_global_option which will look up options in the config attribute of all other registered checkers.

So, theoretically this should work and the passing tests seems to confirm this!

Edit: Never mind, spoke too soon. Let me have a look!

Edit2: You should use black_list. If you look at the definition of "ignore" it has a dest. Same goes for ignore_paths. You should look up their value with self.config."dest".

Copy link
Member Author

@Pierre-Sassoulas Pierre-Sassoulas May 13, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've had to do suspicious fix to make it work, in particular use ignore-patternS or ignore-pathS instead of ignore-pattern or ignore-path in the tests. Did we change an option ? Or maybe we do not check that the full option is used and argparse was handling it ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

e211718

@jacobtylerwalls
Copy link
Member

jacobtylerwalls commented May 13, 2022 •
edited
Loading

Possible to sneak in twoone more fixes? #6602 #6604

@Pierre-Sassoulas Pierre-Sassoulas force-pushed the release-branch-2.13.9 branch from acfe359 to 2884749 Compare May 13, 2022 14:34
@Pierre-Sassoulas Pierre-Sassoulas added the Blocked 🚧 Blocked by a particular issue label May 13, 2022
@Pierre-Sassoulas
Copy link
Member Author

Blocked by a discussion on #6604

@Pierre-Sassoulas Pierre-Sassoulas force-pushed the release-branch-2.13.9 branch from 2884749 to e211718 Compare May 13, 2022 14:45
@Pierre-Sassoulas Pierre-Sassoulas removed the Blocked 🚧 Blocked by a particular issue label May 13, 2022
Pierre-Sassoulas
Pierre-Sassoulas commented May 13, 2022
View reviewed changes
ChangeLog Outdated
@@ -18,8 +18,32 @@ Release date: TBA

What's New in Pylint 2.13.9?
============================
Release date: TBA
Release date: 2022-05-09
Copy link
Member Author

@Pierre-Sassoulas Pierre-Sassoulas May 13, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Release date: 2022-05-09
Release date: 2022-05-13

Need to be done offline so we can rebase-merge and tag a proper historic.

@Pierre-Sassoulas Pierre-Sassoulas force-pushed the release-branch-2.13.9 branch from e211718 to b3a15db Compare May 13, 2022 15:30
@Pierre-Sassoulas Pierre-Sassoulas merged commit 57014d6 into maintenance/2.13.x May 13, 2022
@Pierre-Sassoulas Pierre-Sassoulas deleted the release-branch-2.13.9 branch May 13, 2022 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielNoord DanielNoord DanielNoord left review comments

@jacobtylerwalls jacobtylerwalls jacobtylerwalls left review comments

Assignees
No one assigned
Labels
Maintenance Discussion or action around maintaining pylint or the dev workflow
Projects
None yet
Milestone
2.13.9
Development

Successfully merging this pull request may close these issues.
5 participants
@Pierre-Sassoulas @jacobtylerwalls @DanielNoord @mbyrnepr2 @matusvalo