-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor the primer command to be able to make the comment better later on #6973
Refactor the primer command to be able to make the comment better later on #6973
Conversation
Pull Request Test Coverage Report for Build 2527383993
π - Coveralls |
This comment has been minimized.
This comment has been minimized.
I did not test run/prepare because it's very costly (as costly as launching the primer themself). And it's tested elsewhere. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have the time for a full review and this is quite a big change, but I left some early comments.
It look large but it's really only a copy paste of the existing code to separate the three commands. I could separate the commits in various PR if that would help. |
Yeah, it's just that we'll we're taking a look at this I think it makes sense to see if we haven't forgotten anything with the initial implementation. Such as testing the "too-long-comments". |
1eb7120
to
a6ea2ff
Compare
This comment has been minimized.
This comment has been minimized.
1194eec
to
cf2f1be
Compare
ecf3094
to
20877ca
Compare
π€ According to the primer, this change has no effect on the checked open source code. π€π This comment was generated for commit 20877ca |
Type of Changes
Description
Follow-up to #6969