Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Confirm changes before tbump commit #7666

Merged
merged 1 commit into from
Oct 23, 2022
Merged

Confirm changes before tbump commit #7666

merged 1 commit into from
Oct 23, 2022

Conversation

cdce8p
Copy link
Member

@cdce8p cdce8p commented Oct 23, 2022 •
edited
Loading

Description

Add an additional tbump step to confirm changes before the commit is created.
Found this to be quite helpful when I was doing the patch release.

Refs: https://stackoverflow.com/questions/1885525/how-do-i-prompt-a-user-for-confirmation-in-bash-script

@cdce8p cdce8p added Needs backport Needs to be cherry-picked on the current patch version by a pylint's maintainer Maintenance Discussion or action around maintaining pylint or the dev workflow Skip news 🔇 This change does not require a changelog entry labels Oct 23, 2022
@cdce8p cdce8p added this to the 2.15.6 milestone Oct 23, 2022
@coveralls
Copy link

Pull Request Test Coverage Report for Build 3307821526

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.358%
Totals Coverage Status
Change from base Build 3307801309: 0.0%
Covered Lines: 17172
Relevant Lines: 18008
💛 - Coveralls

Pierre-Sassoulas
Pierre-Sassoulas approved these changes Oct 23, 2022
View reviewed changes
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing !

@Pierre-Sassoulas Pierre-Sassoulas merged commit 38fa174 into pylint-dev:main Oct 23, 2022
@cdce8p cdce8p deleted the tbump-confirm branch October 23, 2022 17:20
@cdce8p cdce8p mentioned this pull request Oct 23, 2022
Merged
@Pierre-Sassoulas Pierre-Sassoulas added Backported and removed Needs backport Needs to be cherry-picked on the current patch version by a pylint's maintainer labels Nov 16, 2022
Pierre-Sassoulas pushed a commit that referenced this pull request Nov 16, 2022
@cdce8p @Pierre-Sassoulas
Confirm changes before tbump commit (#7666)
59470fc
Pierre-Sassoulas pushed a commit that referenced this pull request Nov 17, 2022
@cdce8p @Pierre-Sassoulas
Confirm changes before tbump commit (#7666)
970e14b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pierre-Sassoulas Pierre-Sassoulas Pierre-Sassoulas approved these changes

Assignees
No one assigned
Labels
Backported Maintenance Discussion or action around maintaining pylint or the dev workflow Skip news 🔇 This change does not require a changelog entry
Projects
None yet
Milestone
2.15.6
Development

Successfully merging this pull request may close these issues.
3 participants
@cdce8p @coveralls @Pierre-Sassoulas