-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[compare-to-zero] More actionnable and understandable message #7723
Merged
Pierre-Sassoulas
merged 2 commits into
pylint-dev:main
from
Pierre-Sassoulas:more-actionnable-message-for-compare-to-zΓ©ro
Nov 7, 2022
The head ref may contain hidden characters: "more-actionnable-message-for-compare-to-z\u00E9ro"
Merged
[compare-to-zero] More actionnable and understandable message #7723
Pierre-Sassoulas
merged 2 commits into
pylint-dev:main
from
Pierre-Sassoulas:more-actionnable-message-for-compare-to-zΓ©ro
Nov 7, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pierre-Sassoulas
added
Documentation π
Maintenance
Discussion or action around maintaining pylint or the dev workflow
Skip news π
This change does not require a changelog entry
labels
Nov 6, 2022
Pierre-Sassoulas
force-pushed
the
more-actionnable-message-for-compare-to-zΓ©ro
branch
from
November 6, 2022 16:14
42f96c2
to
6d896f3
Compare
Pull Request Test Coverage Report for Build 3405503653
π - Coveralls |
Pierre-Sassoulas
force-pushed
the
more-actionnable-message-for-compare-to-zΓ©ro
branch
from
November 6, 2022 16:29
6d896f3
to
b0191fe
Compare
This comment has been minimized.
This comment has been minimized.
Drafting as the primer detects false positives where |
Originally done in order to normalize the use-implicit-booleaness check. This make the message more understandable and permit to make pylint-dev#6870 more reviewable.
Pierre-Sassoulas
force-pushed
the
more-actionnable-message-for-compare-to-zΓ©ro
branch
from
November 6, 2022 18:28
73787bf
to
cd5a1bb
Compare
mbyrnepr2
approved these changes
Nov 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
π
Pierre-Sassoulas
deleted the
more-actionnable-message-for-compare-to-zΓ©ro
branch
November 7, 2022 20:30
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Documentation π
Maintenance
Discussion or action around maintaining pylint or the dev workflow
Skip news π
This change does not require a changelog entry
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Originally done in order to normalize the use-implicit-booleaness check. This make the message more understandable and permit to make #6870 more reviewable. Also fix a false positive with
x is False
being falsely detected as a comparison to 0.