Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix false positive for unhashable-member when subclassing dict. #7757

Merged
merged 2 commits into from
Nov 14, 2022
Merged

Fix false positive for unhashable-member when subclassing dict. #7757

merged 2 commits into from
Nov 14, 2022

Conversation

mbyrnepr2
Copy link
Member

Type of Changes

Type
✓ 🐛 Bug fix
✨ New feature
🔨 Refactoring
📜 Docs

Description

Let nodes.ClassDef nodes be considered hashable.

Closes #7501

@coveralls
Copy link

coveralls commented Nov 12, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 3460009541

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 41 unchanged lines in 6 files lost coverage.
  • Overall coverage increased (+0.02%) to 95.402%
Files with Coverage Reduction New Missed Lines %
pylint/checkers/utils.py 1 95.04%
pylint/checkers/base/basic_checker.py 3 97.9%
pylint/checkers/exceptions.py 5 97.85%
pylint/checkers/format.py 9 96.54%
pylint/checkers/refactoring/refactoring_checker.py 9 97.99%
pylint/checkers/typecheck.py 14 96.04%
Totals Coverage Status
Change from base Build 3452587241: 0.02%
Covered Lines: 17346
Relevant Lines: 18182
💛 - Coveralls

@github-actions

This comment has been minimized.

Sign in to view
Pierre-Sassoulas
Pierre-Sassoulas previously approved these changes Nov 13, 2022
View reviewed changes
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

doc/whatsnew/fragments/7501.false_positive Outdated Show resolved Hide resolved
@mbyrnepr2 mbyrnepr2 marked this pull request as ready for review November 14, 2022 09:10
@Pierre-Sassoulas Pierre-Sassoulas added Needs backport Needs to be cherry-picked on the current patch version by a pylint's maintainer False Positive 🦟 A message is emitted but nothing is wrong with the code labels Nov 14, 2022
@Pierre-Sassoulas Pierre-Sassoulas modified the milestones: 2.15.7, 2.15.6 Nov 14, 2022
@Pierre-Sassoulas Pierre-Sassoulas enabled auto-merge (squash) November 14, 2022 09:18
@Pierre-Sassoulas Pierre-Sassoulas merged commit fdd8f18 into pylint-dev:main Nov 14, 2022
@mbyrnepr2 mbyrnepr2 deleted the 7501_unhashable_member branch November 14, 2022 09:35
@github-actions
Copy link
Contributor

🤖 According to the primer, this change has no effect on the checked open source code. 🤖🎉

This comment was generated for commit 80ed477

Pierre-Sassoulas added a commit that referenced this pull request Nov 16, 2022
@mbyrnepr2 @Pierre-Sassoulas
Fix false positive for unhashable-member when subclassing `dict…
1e291d2 
…`. (#7757)

Closes #7501

Co-authored-by: Pierre Sassoulas <[email protected]>
@Pierre-Sassoulas Pierre-Sassoulas added Backported and removed Needs backport Needs to be cherry-picked on the current patch version by a pylint's maintainer labels Nov 16, 2022
Pierre-Sassoulas added a commit that referenced this pull request Nov 17, 2022
@mbyrnepr2 @Pierre-Sassoulas
Fix false positive for unhashable-member when subclassing `dict…
fa618cb 
…`. (#7757)

Closes #7501

Co-authored-by: Pierre Sassoulas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pierre-Sassoulas Pierre-Sassoulas Pierre-Sassoulas approved these changes

Assignees
No one assigned
Labels
Backported False Positive 🦟 A message is emitted but nothing is wrong with the code
Projects
None yet
Milestone
2.15.6
Development

Successfully merging this pull request may close these issues.

False positive E1143 unhashable-member with class type as key
3 participants
@mbyrnepr2 @coveralls @Pierre-Sassoulas