Cancel previous tests when pushing to PRs #8382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobtylerwalls
added
Maintenance
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #8382 +/- ##
=======================================
Coverage 95.56% 95.56%
=======================================
Files 178 178
Lines 18765 18765
=======================================
Hits 17932 17932
Misses 833 833 |
|
I quite like getting the test results for old commits when I break something in a newer commit, but I think that is quite a nice use case. Rest, LGTN |
DanielNoord
approved these changes
Mar 5, 2023
|
Good point, but I do think it's more likely if you're pushing that quickly that you're amending things. |
|
🤖 According to the primer, this change has no effect on the checked open source code. 🤖🎉 This comment was generated for commit fa5be74 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Closes #8285
Extends our existing
concurrencyinfrastructure that cancels some in-progress jobs when a PR is updated to cancel also the tests workflow and the codeql-analysis workflow.Does not affect pushes to main.
Demo
Example cancelled run
