Upgrade astroid to 3.0.0a6

[jacobtylerwalls]

Type of Changes

	Type
✓	✨ New feature

Description

Prerequisite for adding Python 3.12 compatibility. 3.12 CI jobs will be added later in #8718.

Skipping news because we have several pre-releases to go before announcing the astroid version to be used for 3.0 final.

[codecov]

Codecov Report

Merging #8822 (17cc899) into main (f815e9f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #8822   +/-   ##
=======================================
  Coverage   95.89%   95.90%           
=======================================
  Files         173      173           
  Lines       18511    18515    +4     
=======================================
+ Hits        17752    17756    +4     
  Misses        759      759           

Impacted Files	Coverage Δ
pylint/checkers/base/basic_checker.py	97.88% <100.00%> (ø)
pylint/checkers/base/basic_error_checker.py	95.51% <100.00%> (ø)
pylint/checkers/base/docstring_checker.py	97.67% <100.00%> (ø)
pylint/checkers/base/name_checker/checker.py	98.59% <100.00%> (ø)
pylint/checkers/classes/class_checker.py	93.38% <100.00%> (+0.02%)	⬆️
pylint/checkers/format.py	96.46% <100.00%> (ø)
pylint/checkers/imports.py	94.21% <100.00%> (ø)
pylint/checkers/newstyle.py	96.15% <100.00%> (ø)
pylint/checkers/refactoring/not_checker.py	97.22% <100.00%> (ø)
pylint/checkers/refactoring/refactoring_checker.py	98.23% <100.00%> (ø)
... and 9 more

[jacobtylerwalls]

Working on patch for the stdlib primer issue (regression in pylint-dev/astroid#2231) 👀

EDIT: see pylint-dev/astroid#2235

[jacobtylerwalls]

Blocked by pylint-dev/astroid#2237.

[jacobtylerwalls]

Primer result isn't helpful (same result on #8824). I ran it locally. No change. Something's up on CI. I reopened #8790.

I'll remove the commit that pins to my fix branch. Then I suggest merging this in the next few days. main will fail until we get astroid 3.0.0a7 with pylint-dev/astroid#2235, but then the question is whether we do a release for a single hotfix only OR do we just roll in the try node from pylint-dev/astroid#1867 also and publish 3.0.0a7 with that. Slight preference for the latter. The primer being down for a couple days is fine. Then we can work on compatibility with the new try node in a separate PR from this one (#7767).

@Pierre-Sassoulas your thoughts? 🙏

[Pierre-Sassoulas]

Main would fail until we release astroid 3.0.0a7 ?

[jacobtylerwalls]

Yeah, if we merge this then main will fail until we upgrade to the next astroid alpha. If that's not okay, then we can do an astroid alpha just for the regression fix. I just didn't want to create extra work.

Or we can hold this PR and merge it into #7767, but I wanted to avoid that because they're two large PRs.

[Pierre-Sassoulas]

Let's release a new astroid, this is less work than telling all contributors that the primer also fail on main (it's not that much work, two tbump and a tag). Should I release asap ?

[jacobtylerwalls]

Sure! Thanks.

[jacobtylerwalls]

@Pierre-Sassoulas the pin didn't work. The error message from pip is difficult to make sense of. I'll go see if there's an open issue against pip. In any case, should I just rebase #7767 on top of these first three commits and just do a single PR anyway?

[Pierre-Sassoulas]

Let's go with a single PR it seems to be the simpler option ? If not do whatever you find more conveniant :D I'm on mobile I can't release astroid 3.0.0a7 right now, I expect to be able to before tommorow

[jacobtylerwalls]

Never mind! One file said "astroid" and the other said "astroid.git", and standardizing them fixed the pip resolver.

This should be good to merge.

[github-actions]

🤖 According to the primer, this change has no effect on the checked open source code. 🤖🎉

This comment was generated for commit 17cc899