Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[coverage] Invoke pytest as python -m pytest to restore coverage #8902

Merged
merged 7 commits into from
Jul 30, 2023
Merged

[coverage] Invoke pytest as python -m pytest to restore coverage #8902

merged 7 commits into from
Jul 30, 2023

Conversation

jacobtylerwalls
Copy link
Member

Follow-up to #8878. Ideally this will restore the codecov calculations.

@jacobtylerwalls jacobtylerwalls added Maintenance Discussion or action around maintaining pylint or the dev workflow Skip news 🔇 This change does not require a changelog entry labels Jul 30, 2023
@codecov
Copy link

codecov bot commented Jul 30, 2023 •
edited
Loading

Codecov Report

Merging #8902 (1a4cbcd) into main (f8b7403) will increase coverage by 65.68%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #8902       +/-   ##
===========================================
+ Coverage   30.05%   95.74%   +65.68%     
===========================================
  Files          64      173      +109     
  Lines        5017    18570    +13553     
===========================================
+ Hits         1508    17780    +16272     
+ Misses       3509      790     -2719

see 163 files with indirect coverage changes

@jacobtylerwalls jacobtylerwalls marked this pull request as draft July 30, 2023 18:25
@github-actions

This comment has been minimized.

Sign in to view
@jacobtylerwalls
Invoke pytest as python -m pytest
e5c5587 
pytest really wants to invoke tests against the local copy, see
https://docs.pytest.org/en/latest/explanation/goodpractices.html
@jacobtylerwalls jacobtylerwalls marked this pull request as ready for review July 30, 2023 19:09
@jacobtylerwalls jacobtylerwalls changed the title [coverage] Specify installed path [coverage] Invoke pytest as python -m pytest to restore coverage Jul 30, 2023
@jacobtylerwalls
Copy link
Member Author

Maybe this is giving back some of the benefits of #8878, but pytest really seems to want to execute tests against the local copy, and I don't have time to commit to a bigger refactor.

Part of what makes this more difficult is that we don't use a src layout. See #5644, which I'd be wiling to reconsider.

@github-actions

This comment has been minimized.

Sign in to view
@jacobtylerwalls jacobtylerwalls added this to the 3.0.0a7 milestone Jul 30, 2023
@github-actions
Copy link
Contributor

🤖 According to the primer, this change has no effect on the checked open source code. 🤖🎉

This comment was generated for commit 1a4cbcd

@jacobtylerwalls jacobtylerwalls merged commit 2821efb into pylint-dev:main Jul 30, 2023
@jacobtylerwalls jacobtylerwalls deleted the coverage-path branch July 30, 2023 22:24
mbyrnepr2 pushed a commit to mbyrnepr2/pylint that referenced this pull request Aug 3, 2023
@jacobtylerwalls @mbyrnepr2
[coverage] Invoke pytest as python -m pytest to restore coverage (p…
36389f7 
…ylint-dev#8902)

See https://docs.pytest.org/en/latest/explanation/goodpractices.html

Fix doc build
@jacobtylerwalls jacobtylerwalls mentioned this pull request Aug 5, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pierre-Sassoulas Pierre-Sassoulas Pierre-Sassoulas approved these changes

Assignees
No one assigned
Labels
Maintenance Discussion or action around maintaining pylint or the dev workflow Skip news 🔇 This change does not require a changelog entry
Projects
None yet
Milestone
3.0.0a7
Development

Successfully merging this pull request may close these issues.
2 participants
@jacobtylerwalls @Pierre-Sassoulas