pylint-dev · Pierre-Sassoulas · Nov 10, 2023 · Oct 27, 2023 · Oct 27, 2023 · Oct 27, 2023
diff --git a/doc/whatsnew/fragments/8827.false_negative b/doc/whatsnew/fragments/8827.false_negative
@@ -0,0 +1,3 @@
+Extend broad-exception-raised and broad-exception-caught to except*.
+
+Closes #8827
diff --git a/pylint/checkers/base/basic_checker.py b/pylint/checkers/base/basic_checker.py
@@ -478,7 +478,10 @@ def visit_expr(self, node: nodes.Expr) -> None:
         # side effects), else pointless-statement
         if (
             isinstance(expr, (nodes.Yield, nodes.Await))
-            or (isinstance(node.parent, nodes.Try) and node.parent.body == [node])
+            or (
+                isinstance(node.parent, (nodes.Try, nodes.TryStar))
+                and node.parent.body == [node]
+            )
             or (isinstance(expr, nodes.Const) and expr.value is Ellipsis)
         ):
             return

diff --git a/pylint/checkers/exceptions.py b/pylint/checkers/exceptions.py
@@ -556,6 +556,10 @@ def visit_compare(self, node: nodes.Compare) -> None:
         "catching-non-exception",
         "duplicate-except",
     )
+    def visit_trystar(self, node: nodes.TryStar) -> None:
+        """Check for empty except*."""
+        self.visit_try(node)
+
     def visit_try(self, node: nodes.Try) -> None:
         """Check for empty except."""
         self._check_try_except_raise(node)

diff --git a/tests/functional/b/broad_exception_caught.py → ...broad_exception/broad_exception_caught.py b/tests/functional/b/broad_exception_caught.py → ...broad_exception/broad_exception_caught.py
diff --git a/tests/functional/b/broad_exception/broad_exception_caught.rc b/tests/functional/b/broad_exception/broad_exception_caught.rc
@@ -0,0 +1,5 @@
+[EXCEPTIONS]
+overgeneral-exceptions=builtins.BaseException,
+                       builtins.Exception,
+                       functional.b.broad_exception.broad_exception_caught.CustomBroadException,
+                       broad_exception_caught.CustomBroadException
diff --git a/...s/functional/b/broad_exception_caught.txt → ...road_exception/broad_exception_caught.txt b/...s/functional/b/broad_exception_caught.txt → ...road_exception/broad_exception_caught.txt
@@ -1,3 +1,3 @@
-broad-exception-caught:14:7:14:16::Catching too general exception Exception:INFERENCE
-broad-exception-caught:20:7:20:20::Catching too general exception BaseException:INFERENCE
-broad-exception-caught:32:7:32:27::Catching too general exception CustomBroadException:INFERENCE
+broad-exception-caught:14:7:14:16::Catching too general exception Exception:INFERENCE
+broad-exception-caught:20:7:20:20::Catching too general exception BaseException:INFERENCE
+broad-exception-caught:32:7:32:27::Catching too general exception CustomBroadException:INFERENCE
diff --git a/tests/functional/b/broad_exception/broad_exception_caught_trystar.py b/tests/functional/b/broad_exception/broad_exception_caught_trystar.py
@@ -0,0 +1,39 @@
+# pylint: disable=missing-docstring
+__revision__ = 0
+
+class CustomBroadException(Exception):
+    pass
+
+
+class CustomNarrowException(CustomBroadException):
+    pass
+
+
+try:
+    __revision__ += 1
+except* Exception: # [broad-exception-caught]
+    print('error')
+
+
+try:
+    __revision__ += 1
+except* BaseException: # [broad-exception-caught]
+    print('error')
+
+
+try:
+    __revision__ += 1
+except* ValueError:
+    print('error')
+
+
+try:
+    __revision__ += 1
+except CustomBroadException: # [broad-exception-caught]
+    print('error')
+
+
+try:
+    __revision__ += 1
+except* CustomNarrowException:
+    print('error')
diff --git a/tests/functional/b/broad_exception/broad_exception_caught_trystar.rc b/tests/functional/b/broad_exception/broad_exception_caught_trystar.rc
@@ -0,0 +1,8 @@
+[EXCEPTIONS]
+overgeneral-exceptions=builtins.BaseException,
+                       builtins.Exception,
+                       functional.b.broad_exception.broad_exception_caught_trystar.CustomBroadException,
+                       broad_exception_caught_trystar.CustomBroadException
+
+[testoptions]
+min_pyver=3.11
diff --git a/tests/functional/b/broad_exception/broad_exception_caught_trystar.txt b/tests/functional/b/broad_exception/broad_exception_caught_trystar.txt
@@ -0,0 +1,3 @@
+broad-exception-caught:14:8:14:17::Catching too general exception Exception:INFERENCE
+broad-exception-caught:20:8:20:21::Catching too general exception BaseException:INFERENCE
+broad-exception-caught:32:7:32:27::Catching too general exception CustomBroadException:INFERENCE
diff --git a/tests/functional/b/broad_exception_raised.py → ...broad_exception/broad_exception_raised.py b/tests/functional/b/broad_exception_raised.py → ...broad_exception/broad_exception_raised.py
diff --git a/tests/functional/b/broad_exception/broad_exception_raised.rc b/tests/functional/b/broad_exception/broad_exception_raised.rc
@@ -0,0 +1,5 @@
+[EXCEPTIONS]
+overgeneral-exceptions=builtins.BaseException,
+                       builtins.Exception,
+                       functional.b.broad_exception.broad_exception_raised.CustomBroadException,
+                       broad_exception_raised.CustomBroadException
diff --git a/...s/functional/b/broad_exception_raised.txt → ...road_exception/broad_exception_raised.txt b/...s/functional/b/broad_exception_raised.txt → ...road_exception/broad_exception_raised.txt
@@ -1,8 +1,8 @@
-broad-exception-raised:15:4:15:41:exploding_apple:"Raising too general exception: Exception":INFERENCE
-broad-exception-raised:20:8:20:34:raise_and_catch:"Raising too general exception: Exception":INFERENCE
-broad-exception-caught:21:11:21:20:raise_and_catch:Catching too general exception Exception:INFERENCE
-broad-exception-raised:38:8:38:35:raise_catch_raise:"Raising too general exception: Exception":INFERENCE
-broad-exception-raised:46:8:46:40:raise_catch_raise_using_alias:"Raising too general exception: Exception":INFERENCE
-broad-exception-raised:48:0:48:17::"Raising too general exception: Exception":INFERENCE
-broad-exception-raised:49:0:49:21::"Raising too general exception: BaseException":INFERENCE
-broad-exception-raised:50:0:50:28::"Raising too general exception: CustomBroadException":INFERENCE
+broad-exception-raised:15:4:15:41:exploding_apple:"Raising too general exception: Exception":INFERENCE
+broad-exception-raised:20:8:20:34:raise_and_catch:"Raising too general exception: Exception":INFERENCE
+broad-exception-caught:21:11:21:20:raise_and_catch:Catching too general exception Exception:INFERENCE
+broad-exception-raised:38:8:38:35:raise_catch_raise:"Raising too general exception: Exception":INFERENCE
+broad-exception-raised:46:8:46:40:raise_catch_raise_using_alias:"Raising too general exception: Exception":INFERENCE
+broad-exception-raised:48:0:48:17::"Raising too general exception: Exception":INFERENCE
+broad-exception-raised:49:0:49:21::"Raising too general exception: BaseException":INFERENCE
+broad-exception-raised:50:0:50:28::"Raising too general exception: CustomBroadException":INFERENCE
diff --git a/tests/functional/b/broad_exception/broad_exception_raised_trystar.py b/tests/functional/b/broad_exception/broad_exception_raised_trystar.py
@@ -0,0 +1,52 @@
+# pylint: disable=missing-docstring, unreachable
+
+ExceptionAlias = Exception
+
+class CustomBroadException(Exception):
+    pass
+
+
+class CustomNarrowException(CustomBroadException):
+    pass
+
+
+def exploding_apple(apple):
+    print(f"{apple} is about to explode")
+    raise Exception("{apple} exploded !")  # [broad-exception-raised]
+
+
+def raise_and_catch_star():
+    try:
+        raise Exception("Oh No!!")  # [broad-exception-raised]
+    except* Exception as ex:  # [broad-exception-caught]
+        print(ex)
+
+
+def raise_catch_reraise_star():
+    try:
+        exploding_apple("apple")
+    except* Exception as ex:
+        print(ex)
+        raise ex
+
+
+def raise_catch_raise_star():
+    try:
+        exploding_apple("apple")
+    except* Exception as ex:
+        print(ex)
+        raise Exception() from None  # [broad-exception-raised]
+
+
+def raise_catch_raise_using_alias_star():
+    try:
+        exploding_apple("apple")
+    except* Exception as ex:
+        print(ex)
+        raise ExceptionAlias() from None  # [broad-exception-raised]
+
+raise Exception()  # [broad-exception-raised]
+raise BaseException()  # [broad-exception-raised]
+raise CustomBroadException()  # [broad-exception-raised]
+raise IndexError from None
+raise CustomNarrowException() from None
diff --git a/tests/functional/b/broad_exception/broad_exception_raised_trystar.rc b/tests/functional/b/broad_exception/broad_exception_raised_trystar.rc
@@ -0,0 +1,7 @@
+[EXCEPTIONS]
+overgeneral-exceptions=builtins.BaseException,
+                       builtins.Exception,
+                       functional.b.broad_exception.broad_exception_raised_trystar.CustomBroadException,
+                       broad_exception_raised_trystar.CustomBroadException
+[testoptions]
+min_pyver=3.11
diff --git a/tests/functional/b/broad_exception/broad_exception_raised_trystar.txt b/tests/functional/b/broad_exception/broad_exception_raised_trystar.txt
@@ -0,0 +1,8 @@
+broad-exception-raised:15:4:15:41:exploding_apple:"Raising too general exception: Exception":INFERENCE
+broad-exception-raised:20:8:20:34:raise_and_catch_star:"Raising too general exception: Exception":INFERENCE
+broad-exception-caught:21:12:21:21:raise_and_catch_star:Catching too general exception Exception:INFERENCE
+broad-exception-raised:38:8:38:35:raise_catch_raise_star:"Raising too general exception: Exception":INFERENCE
+broad-exception-raised:46:8:46:40:raise_catch_raise_using_alias_star:"Raising too general exception: Exception":INFERENCE
+broad-exception-raised:48:0:48:17::"Raising too general exception: Exception":INFERENCE
+broad-exception-raised:49:0:49:21::"Raising too general exception: BaseException":INFERENCE
+broad-exception-raised:50:0:50:28::"Raising too general exception: CustomBroadException":INFERENCE
diff --git a/tests/functional/b/broad_exception_caught.rc b/tests/functional/b/broad_exception_caught.rc
diff --git a/tests/functional/b/broad_exception_raised.rc b/tests/functional/b/broad_exception_raised.rc
diff --git a/tests/pyreverse/functional/class_diagrams/colorized_output/colorized.puml b/tests/pyreverse/functional/class_diagrams/colorized_output/colorized.puml
@@ -21,6 +21,7 @@ class "ExceptionsChecker" as pylint.checkers.exceptions.ExceptionsChecker #44BB9
   visit_compare(node: nodes.Compare) -> None
   visit_raise(node: nodes.Raise) -> None
   visit_try(node: nodes.Try) -> None
+  visit_trystar(node: nodes.TryStar) -> None
 }
 class "StdlibChecker" as pylint.checkers.stdlib.StdlibChecker #44BB99 {
   msgs : dict[str, MessageDefinitionTuple]

diff --git a/tests/pyreverse/functional/class_diagrams/colorized_output/custom_colors.dot b/tests/pyreverse/functional/class_diagrams/colorized_output/custom_colors.dot
@@ -3,7 +3,7 @@ rankdir=BT
 charset="utf-8"
 "custom_colors.CheckerCollector" [color="red", fontcolor="black", label=<{CheckerCollector|checker1<br ALIGN="LEFT"/>checker2<br ALIGN="LEFT"/>checker3<br ALIGN="LEFT"/>|}>, shape="record", style="filled"];
 "pylint.extensions.check_elif.ElseifUsedChecker" [color="#44BB88", fontcolor="black", label=<{ElseifUsedChecker|msgs : dict<br ALIGN="LEFT"/>name : str<br ALIGN="LEFT"/>|leave_module(_: nodes.Module): None<br ALIGN="LEFT"/>process_tokens(tokens: list[TokenInfo]): None<br ALIGN="LEFT"/>visit_if(node: nodes.If): None<br ALIGN="LEFT"/>}>, shape="record", style="filled"];
-"pylint.checkers.exceptions.ExceptionsChecker" [color="yellow", fontcolor="black", label=<{ExceptionsChecker|msgs : dict<br ALIGN="LEFT"/>name : str<br ALIGN="LEFT"/>options : tuple<br ALIGN="LEFT"/>|open(): None<br ALIGN="LEFT"/>visit_binop(node: nodes.BinOp): None<br ALIGN="LEFT"/>visit_compare(node: nodes.Compare): None<br ALIGN="LEFT"/>visit_raise(node: nodes.Raise): None<br ALIGN="LEFT"/>visit_try(node: nodes.Try): None<br ALIGN="LEFT"/>}>, shape="record", style="filled"];
+"pylint.checkers.exceptions.ExceptionsChecker" [color="yellow", fontcolor="black", label=<{ExceptionsChecker|msgs : dict<br ALIGN="LEFT"/>name : str<br ALIGN="LEFT"/>options : tuple<br ALIGN="LEFT"/>|open(): None<br ALIGN="LEFT"/>visit_binop(node: nodes.BinOp): None<br ALIGN="LEFT"/>visit_compare(node: nodes.Compare): None<br ALIGN="LEFT"/>visit_raise(node: nodes.Raise): None<br ALIGN="LEFT"/>visit_try(node: nodes.Try): None<br ALIGN="LEFT"/>visit_trystar(node: nodes.TryStar): None<br ALIGN="LEFT"/>}>, shape="record", style="filled"];
 "pylint.checkers.stdlib.StdlibChecker" [color="yellow", fontcolor="black", label=<{StdlibChecker|msgs : dict[str, MessageDefinitionTuple]<br ALIGN="LEFT"/>name : str<br ALIGN="LEFT"/>|deprecated_arguments(method: str): tuple[tuple[int \| None, str], ...]<br ALIGN="LEFT"/>deprecated_attributes(): Iterable[str]<br ALIGN="LEFT"/>deprecated_classes(module: str): Iterable[str]<br ALIGN="LEFT"/>deprecated_decorators(): Iterable[str]<br ALIGN="LEFT"/>deprecated_methods(): set[str]<br ALIGN="LEFT"/>visit_boolop(node: nodes.BoolOp): None<br ALIGN="LEFT"/>visit_call(node: nodes.Call): None<br ALIGN="LEFT"/>visit_functiondef(node: nodes.FunctionDef): None<br ALIGN="LEFT"/>visit_if(node: nodes.If): None<br ALIGN="LEFT"/>visit_ifexp(node: nodes.IfExp): None<br ALIGN="LEFT"/>visit_unaryop(node: nodes.UnaryOp): None<br ALIGN="LEFT"/>}>, shape="record", style="filled"];
 "pylint.checkers.exceptions.ExceptionsChecker" -> "custom_colors.CheckerCollector" [arrowhead="diamond", arrowtail="none", fontcolor="green", label="checker1", style="solid"];
 "pylint.checkers.stdlib.StdlibChecker" -> "custom_colors.CheckerCollector" [arrowhead="diamond", arrowtail="none", fontcolor="green", label="checker3", style="solid"];

diff --git a/tests/pyreverse/functional/class_diagrams/colorized_output/custom_colors.puml b/tests/pyreverse/functional/class_diagrams/colorized_output/custom_colors.puml
@@ -21,6 +21,7 @@ class "ExceptionsChecker" as pylint.checkers.exceptions.ExceptionsChecker #yello
   visit_compare(node: nodes.Compare) -> None
   visit_raise(node: nodes.Raise) -> None
   visit_try(node: nodes.Try) -> None
+  visit_trystar(node: nodes.TryStar) -> None
 }
 class "StdlibChecker" as pylint.checkers.stdlib.StdlibChecker #yellow {
   msgs : dict[str, MessageDefinitionTuple]
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,3 @@
		Extend broad-exception-raised and broad-exception-caught to except*.

		Closes #8827