README: refactor addons section; other fixes; fix GEOLOCATION/QUIET FOX sections of #208 #255
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -6,6 +6,7 @@ before_script: | |
| script: | ||
| - acorn user.js | ||
| - bash -n cas.sh | ||
| - make tests | ||
| notifications: | ||
| irc: | ||
| channels: | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| pyllyukko <[email protected]> | ||
| nodiscc <[email protected]> | ||
| CHEF-KOCH <[email protected]> | ||
| Francois Marier <[email protected]> | ||
| CHEF-KOCH <[email protected]> | ||
| Francois Marier <[email protected]> | ||
| Alex Hirsch <[email protected]> | ||
| DrunkenSasquatch <[email protected]> | ||
| Frank LENORMAND <[email protected]> | ||
| Sebastian Schmidt <[email protected]> | ||
| Steffen Gransow <[email protected]> | ||
| devmapper0 <[email protected]> | ||
| Mehmet Atif Ergun <[email protected]> | ||
| mengele-chan <[email protected]> | ||
| uberspot <[email protected]> | ||
| zummuz <[email protected]> | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,56 @@ | ||
| all: whatdoesitdo tests authors | ||
|
|
||
| whatdoesitdo: | ||
| @# generate the README "What does it do?" section | ||
| @./gen-readme.sh | ||
|
|
||
| # To decrease tests verbosity, comment out unneeded targets | ||
| tests: downloadffprefs checknotcovered checkdeprecated stats cleanup | ||
|
There was a problem hiding this comment. This will fail horribly if you have e.g. I'm not entirely sure what is the proper way to fix it, as I'm not that familiar with makefiles. Maybe with .NOTPARALLEL? There was a problem hiding this comment. Yes apparently a target named There was a problem hiding this comment. Cool, that's what I thought. I'm still not sure as to where and how to add it. e.g., should it be like: Or just as it's own line? It wasn't completely clear to me. There was a problem hiding this comment. I forgot to post the link I found: http://stackoverflow.com/questions/4346399/how-can-i-force-gnu-make-to-not-build-recipe-in-parallel/23903293#23903293 Apparently on it's own line. The MAKEFLAGS variable can also be used (solution 3) There was a problem hiding this comment. Yeah I saw that post also when I was looking at the subject. Is it so, that everything below that will not run as parallel or what? I mean there are still some things, that can be run as parallel in the makefile, e.g. There was a problem hiding this comment.
This is what it looks like, but I have no experience with parallel usage of Make - very interesting, I really need to read the full Make manual. Unfortunately no time to work on it at the moment, would you be ok to apply the global |
||
|
|
||
|
|
||
| downloadffprefs: | ||
| @# download and sort all known preferences files from Firefox (mozilla-central) source | ||
| @# specify wanted Firefox version/revision below (eg. "tip", "FIREFOX_AURORA_45_BASE", "9577ddeaafd85554c2a855f385a87472a089d5c0"). See https://hg.mozilla.org/mozilla-central/tags | ||
| @SOURCEVERSION="tip"; \ | ||
| FIREFOX_SOURCE_PREFS=" \ | ||
| https://hg.mozilla.org/mozilla-central/raw-file/$$SOURCEVERSION/toolkit/components/telemetry/datareporting-prefs.js \ | ||
| https://hg.mozilla.org/mozilla-central/raw-file/$$SOURCEVERSION/toolkit/components/telemetry/healthreport-prefs.js \ | ||
| https://hg.mozilla.org/mozilla-central/raw-file/$$SOURCEVERSION/security/manager/ssl/security-prefs.js \ | ||
| https://hg.mozilla.org/mozilla-central/raw-file/$$SOURCEVERSION/modules/libpref/init/all.js \ | ||
| https://hg.mozilla.org/mozilla-central/raw-file/$$SOURCEVERSION/testing/profiles/prefs_general.js \ | ||
| https://hg.mozilla.org/mozilla-central/raw-file/$$SOURCEVERSION/layout/tools/reftest/reftest-preferences.js \ | ||
| https://hg.mozilla.org/mozilla-central/raw-file/$$SOURCEVERSION/js/src/tests/user.js"; \ | ||
| for SOURCEFILE in $$FIREFOX_SOURCE_PREFS; do wget "$$SOURCEFILE" -O - ; done | egrep "(^pref|^user_pref)" | sort --unique >| sourceprefs.js | ||
|
|
||
| ###################### | ||
|
|
||
| checknotcovered: | ||
| @# check for preferences present in firefox source but not covered by user.js | ||
| @# configure ignored preferences in ignore.list | ||
| @SOURCE_PREFS=$$(egrep '(^pref|^user_pref)' sourceprefs.js | awk -F'"' '{print $$2}'); \ | ||
| for SOURCE_PREF in $$SOURCE_PREFS; do \ | ||
| grep "\"$$SOURCE_PREF\"" user.js ignore.list >/dev/null || echo "Not covered by user.js : $$SOURCE_PREF"; \ | ||
| done | sort --unique | ||
|
|
||
| checkdeprecated: | ||
| @# check for preferences in hardened user.js that are no longer present in firefox source | ||
| @HARDENED_PREFS=$$(egrep "^user_pref" user.js | cut -d'"' -f2); \ | ||
| for HARDENED_PREF in $$HARDENED_PREFS; do \ | ||
| grep "\"$$HARDENED_PREF\"" sourceprefs.js >/dev/null || echo "Deprecated : $$HARDENED_PREF"; \ | ||
| done | sort --unique | ||
|
|
||
| stats: | ||
| @# count preferences number, various stats | ||
| @echo "$$(egrep "^user_pref" user.js | wc -l | cut -f1) preferences in user.js" | ||
| @echo "$$(wc -l sourceprefs.js | cut -d" " -f1) preferences in Firefox source" | ||
|
|
||
| cleanup: | ||
| @# remove temporary files | ||
| @# please comment this out when not needed, to minimize load on Mozilla servers | ||
| @rm sourceprefs.js | ||
|
|
||
| authors: | ||
| @# generate an AUTHORS file, ordered by number of commits | ||
| @# TODO: add a .mailmap file to deduplicate authors with multiple email addresses | ||
| @# to add extra authors/credits, git commit --allow-empty --author="A U Thor <[email protected]>" | ||
| @git shortlog -sne | cut -f1 --complement >| AUTHORS | ||
|
There was a problem hiding this comment. BTW. would the following There was a problem hiding this comment. Yes it works with these contents (I just tested it with There was a problem hiding this comment. I added it with 563c4c6. Even though I removed the AUTHORS file, but it's still better to get exact stats :) One thing that is wrong here, is that there are so many people who have contributed through insights in issues & PRs, but haven't pushed any commits. We would need to have yet-another-script that queries GitHub's API for all the people involved in here to have a complete list :) There was a problem hiding this comment. As far as I know there is no way to (directly) list users who posted in a github project issue tracker. But it can be parsed from https://api.github.com/repos/pyllyukko/user.js/issues ( There was a problem hiding this comment. It was a joke, we don't need to do that :) |
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| // List of preferences to ignore during comparison with Firefox upstream prefs | ||
| // Preference names must use double quotes | ||
|
|
||
| // Don't touch Firefox social API preferences, fully opt-in, WONTFIX | ||
| "toolkit.telemetry.unifiedIsOptIn" | ||
| "social.whitelist" | ||
| "social.toast-notifications.enabled" | ||
| "social.shareDirectory" | ||
| "social.remote-install.enabled" | ||
| "social.directories" | ||
| "social.share.activationPanelEnabled" | ||
| "social.enabled" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not needed. All the info is available as metadata.