Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pathfinder progress bar display not completing #420

Merged
merged 3 commits into from
Feb 18, 2025

Conversation

aphc14
Copy link
Contributor

@aphc14 aphc14 commented Jan 29, 2025

Issue

  • Progress bar percentage is not refreshed after the pathfinder finishes, leaving the completion percentage less than 100%

Changes

  • Progress bar percentage is refreshed after completion to display progress of 100%
  • Add progress bar details of the number of paths complete. Users can opt to stop progress (via Keyboard Interrupt) knowing the number of paths completed rather than as a percentage.

- Progress bar percentage is refreshed after completion to display progress of 100%
- Add progress bar details of the number of paths complete
@aphc14
Copy link
Contributor Author

aphc14 commented Jan 31, 2025

I think parts of the pymc-extras/.github/workflows/pypi.yml needs to be changed: from actions/download-artifact@v3 to actions/download-artifact@v4

@ricardoV94 ricardoV94 merged commit ec46270 into pymc-devs:main Feb 18, 2025
5 checks passed
@ricardoV94 ricardoV94 changed the title fix: progress bar display Fix pathfinder progress bar display not completing Feb 18, 2025
@aphc14 aphc14 deleted the fix-incomplete-progressbar branch February 18, 2025 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants