Direct tests for dispatch implementations in alternative backends #1021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardoV94
commented
Oct 7, 2024
| @@ -78,7 +78,7 @@ jobs: | |||
| install-jax: [0] | |||
| install-torch: [0] | |||
| part: | |||
| - "--doctest-modules --ignore=pytensor/misc/check_duplicate_key.py pytensor --ignore=pytensor/link" | |||
| - "--doctest-modules pytensor --ignore=pytensor/misc/check_duplicate_key.py --ignore=pytensor/link" | |||
There was a problem hiding this comment.
Just odd to have pytensor in the middle of the ignore files
ricardoV94
force-pushed
the
xfail_strict
branch
5 times, most recently
from
77fffef to
f3e8575
Compare
ricardoV94
commented
Oct 8, 2024
| testpaths = "tests/" | ||
| [tool.pytest.ini_options] | ||
| addopts = "--durations=50 --doctest-modules --ignore=pytensor/link --ignore=pytensor/misc/check_duplicate_key.py" | ||
| testpaths = ["pytensor/", "tests/"] |
There was a problem hiding this comment.
pytensor is in the testpath because of --doctest-modules, so we test the code examples in the docstrings by default
ricardoV94
force-pushed
the
xfail_strict
branch
from
f3e8575 to
5449562
Compare
ricardoV94
force-pushed
the
xfail_strict
branch
2 times, most recently
from
2cab125 to
b5a0ca1
Compare
ricardoV94
force-pushed
the
xfail_strict
branch
from
b5a0ca1 to
464805a
Compare
Only run required rewrites in JAX tests Several tests ended up not testing the backend Op implementations due to constant folding of inputs.
ricardoV94
force-pushed
the
xfail_strict
branch
from
464805a to
1590dfa
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1021 +/- ##
==========================================
+ Coverage 81.81% 81.89% +0.07%
==========================================
Files 182 182
Lines 47778 47778
Branches 8597 8597
==========================================
+ Hits 39088 39126 +38
+ Misses 6523 6487 -36
+ Partials 2167 2165 -2
|
ricardoV94
changed the title
twiecki
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does a bunch of minor cleanups on the testing suite:
📚 Documentation preview 📚: https://pytensor--1021.org.readthedocs.build/en/1021/