-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Torch dispatch for scipy-like functions and Softplus #1066
Conversation
I'm okay with closing this, just want to get your thoughts on it in relation to #1065 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1066 +/- ##
=======================================
Coverage 82.12% 82.12%
=======================================
Files 183 183
Lines 48016 48035 +19
Branches 8648 8650 +2
=======================================
+ Hits 39433 39450 +17
- Misses 6417 6418 +1
- Partials 2166 2167 +1
|
This looks fine why did you ask about closing it? Can you add some small tests for one of the scipy ops and the softplus? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, just a nit in the tests
822d23d
to
d17d4a9
Compare
@Ch0ronomato can you fix the conflicts, should be simple |
a5f329e
to
7fec045
Compare
Description
I was goofing around with pymc using the pytorch backend. I implemented a beta binomial model and had an issue when supporting some scipy methods, and was missing softplus. I wrote some small shims. Let me know your thoughts on the importlib stuff.
Related Issue
Checklist
Type of change
📚 Documentation preview 📚: https://pytensor--1066.org.readthedocs.build/en/1066/