Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the codespell pre-commit hook #408

Merged

Conversation

westford14
Copy link

@westford14 westford14 commented Sep 13, 2024

Create the codespell pre-commit hook check. There is more discussion in this, now closed, PR on why we are ignoring the *.ipynb files for the pre-commit hook (and moving those checks to a new CI job).


📚 Documentation preview 📚: https://causalpy--408.org.readthedocs.build/en/408/

@westford14
Copy link
Author

@drbenvincent -- here's the PR for just the pre-commit check

@westford14 westford14 force-pushed the westford14/pre-commit-codespell branch from 3477bf4 to 71d3d09 Compare September 13, 2024 13:27
@westford14 westford14 force-pushed the westford14/pre-commit-codespell branch from 71d3d09 to 6aadfe4 Compare September 13, 2024 13:33
Copy link

codecov bot commented Sep 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.35%. Comparing base (66c2623) to head (6aadfe4).
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #408   +/-   ##
=======================================
  Coverage   94.35%   94.35%           
=======================================
  Files          30       30           
  Lines        1967     1967           
=======================================
  Hits         1856     1856           
  Misses        111      111           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@westford14
Copy link
Author

@drbenvincent -- once this gets merged in i'll push up the notebook PR since it's built off of this branch

@drbenvincent drbenvincent self-requested a review September 16, 2024 10:23
Copy link
Collaborator

@drbenvincent drbenvincent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - thanks for the PR @westford14!

@drbenvincent drbenvincent added the devops DevOps related label Sep 16, 2024
@drbenvincent drbenvincent merged commit f0ffe8d into pymc-labs:main Sep 16, 2024
8 checks passed
@westford14 westford14 deleted the westford14/pre-commit-codespell branch September 16, 2024 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops DevOps related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants