Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove abstract method of data_setter #1463

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

wd60622
Copy link
Contributor

@wd60622 wd60622 commented Feb 3, 2025

Description

I've removed the implementation for the CLV classes since the sample_posterior_predictive methods are not used in those models.

CC: @ColtAllen

Related Issue

  • Closes #
  • Related to #

Checklist


📚 Documentation preview 📚: https://pymc-marketing--1463.org.readthedocs.build/en/1463/

@github-actions github-actions bot added CLV tests ModelBuilder Related to the ModelBuilder class and its children labels Feb 3, 2025
@wd60622
Copy link
Contributor Author

wd60622 commented Feb 3, 2025

Looking at how the customer choice model uses this, I am second guessing. For instance, if there is in sample posterior predictive then this wouldn't really make sense.

However, X is always required for the method at the moment. So maybe it makes sense...

What are people thoughts?

@ColtAllen
Copy link
Collaborator

I've removed the implementation for the CLV classes since the sample_posterior_predictive methods are not used in those models.

pymc.sample_posterior_predictive is being called for the plot_expected_purchases_ppc function. I haven't tested the ModelBuilder variant yet, but given how it's currently handling X data, CLV support might be possible.

Copy link

codecov bot commented Feb 3, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 94.61%. Comparing base (0750eba) to head (edb4ae5).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pymc_marketing/model_builder.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1463      +/-   ##
==========================================
- Coverage   94.70%   94.61%   -0.10%     
==========================================
  Files          50       50              
  Lines        5458     5457       -1     
==========================================
- Hits         5169     5163       -6     
- Misses        289      294       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wd60622
Copy link
Contributor Author

wd60622 commented Feb 3, 2025

pymc.sample_posterior_predictive is being called for the plot_expected_purchases_ppc function. I haven't tested the ModelBuilder variant yet, but given how it's currently handling X data, CLV support might be possible.

sample_posterior_predictive method and not the pymc function

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLV maintenance ModelBuilder Related to the ModelBuilder class and its children tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants