Fix for halt on connect and disconnect resume #304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c1728p9
approved these changes
Jul 7, 2017
|
/morph test |
|
This PR is failing on all non-Kinetis devices - lpc1114, lpc4088dm, lpc824, nrf51. |
|
Thanks. I'll look into it. Do you have any details about the failures? |
|
It was failing only on the ConnectTest for those targets. I don't have access to the logs now so I can't give much more detail. |
|
Alright, thanks. I'll see if it fails on the LPC1768. |
|
/morph test |
flit
force-pushed
the
dev_halt_resume
branch
2 times, most recently
from
50efd6b to
8e79a23
Compare
|
/morph test |
- Control over halt on connect and disconnect resume was broken because the option flags were not being passed to the CortexM class.
|
/morph test |
|
CI results: Mac passed, Linux passed except for a device that's currently stuck in bootloader, Windows build machine is nonfunctional and failing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The halt on connect and disconnect resume features were broken due to the options not being properly passed down to the
CortexMinstance, and the change to clear the DHCSR upon disconnect. This changeset does just that.When a core is added in
CoreSightTarget.add_core(), the halt on connect setting to set on the new core instance. (add_core()is expected to be called before the core is inited.)For disconnect resume, the code in
Board.uninit()to resume the target was removed. Instead, the resume parameter is passed to the target'sdisconnect()method, which passes it toCortexM.disconnect()for each core. The core will not clear DHCSR if resume is not requested.This change includes a comprehensive test for these features.