Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve package build instructions #2633

Merged
merged 7 commits into from
May 29, 2022
Merged

Conversation

josephrocca
Copy link
Contributor

@josephrocca josephrocca commented May 28, 2022

Per this comment by @hoodmane.

Note that I haven't added the run_docker instructions because I don't know how to set the -v flag like I've done here (using the docker run command manually).

What would be the approximate equivalent of this if using run_docker?

git clone https://github.com/pyodide/pyodide
cd pyodide
docker run --rm -it -v $(pwd):/pyodide -w /pyodide pyodide:latest bash
make

(Or is it not necessary to mount a volume? Wondering how else it'd be possible to conveniently get the built files out of the docker container.)

Copy link
Member

@hoodmane hoodmane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @josephrocca!

@hoodmane
Copy link
Member

(Or is it not necessary to mount a volume? Wondering how else it'd be possible to conveniently get the built files out of the docker container.)

Well run_docker mounts the current working directory as /src:

-v "$PWD":/src \

@josephrocca
Copy link
Contributor Author

Well run_docker mounts the current working directory as /src:

Thanks, I've added this to the instructions.

@hoodmane hoodmane merged commit 415681d into pyodide:main May 29, 2022
@hoodmane
Copy link
Member

Thanks @josephrocca!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants