-
-
Notifications
You must be signed in to change notification settings - Fork 887
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve package build instructions #2633
Conversation
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @josephrocca!
Well Line 125 in f3c8445
|
Co-authored-by: Hood Chatham <[email protected]>
Co-authored-by: Hood Chatham <[email protected]>
for more information, see https://pre-commit.ci
Thanks, I've added this to the instructions. |
Thanks @josephrocca! |
Per this comment by @hoodmane.
Note that I haven't added the
run_docker
instructions because I don't know how to set the-v
flag like I've done here (using thedocker run
command manually).What would be the approximate equivalent of this if using
run_docker
?(Or is it not necessary to mount a volume? Wondering how else it'd be possible to conveniently get the built files out of the docker container.)