Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: when control has dimension (1,1) it helps #931

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Ipuch
Copy link
Collaborator

@Ipuch Ipuch commented Feb 25, 2025

This change is Reviewable

@Ipuch Ipuch added the enhancement New feature or request label Feb 25, 2025
@Ipuch Ipuch changed the title fix: when control has dimension (1,1) it helps [RTR] fix: when control has dimension (1,1) it helps Feb 25, 2025
Copy link
Member

@pariterre pariterre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Ipuch)


bioptim/limits/penalty_option.py line 453 at r1 (raw file):

                state_cx_end = controller.states_scaled.cx_end
            elif self.integration_rule == QuadratureRule.TRAPEZOIDAL:
                u_integrate = u.reshape((-1, 2)) if u.shape[0] == 2 else u.T

This should be done in get_variable_inputs

@pariterre pariterre changed the title [RTR] fix: when control has dimension (1,1) it helps fix: when control has dimension (1,1) it helps Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants