Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RTM] refactor: Plot #932

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

[RTM] refactor: Plot #932

wants to merge 5 commits into from

Conversation

Ipuch
Copy link
Collaborator

@Ipuch Ipuch commented Feb 25, 2025

The refactor.


This change is Reviewable

Copy link

codecov bot commented Feb 25, 2025

Codecov Report

Attention: Patch coverage is 81.61435% with 41 lines in your changes missing coverage. Please review.

Project coverage is 77.90%. Comparing base (f3b330a) to head (7d709cf).
Report is 12 commits behind head on master.

Files with missing lines Patch % Lines
bioptim/gui/plot.py 81.53% 41 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #932      +/-   ##
==========================================
+ Coverage   77.79%   77.90%   +0.10%     
==========================================
  Files         157      157              
  Lines       18071    18133      +62     
==========================================
+ Hits        14059    14126      +67     
+ Misses       4012     4007       -5     
Flag Coverage Δ
unittests 77.90% <81.61%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Ipuch Ipuch changed the title reafactor: Plot [RTR] refactor: Plot Feb 25, 2025
Copy link
Member

@pariterre pariterre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Ipuch)

@pariterre pariterre changed the title [RTR] refactor: Plot [RTM] refactor: Plot Mar 3, 2025
@pariterre
Copy link
Member

@EveCharbie
Is it okay?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants