-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Model creation (BIS) #358
Model creation (BIS) #358
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
Please update for the last remaining comment and we are good to go :D
Reviewed 20 of 20 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @EveCharbie)
binding/python3/model_creation/segment_real.py
line 58 at r1 (raw file):
if self.rotations != Rotations.NONE: out_string += f"\trotations\t{self.rotations.value}\n" if self.q_ranges != None:
For very subtle reasons in Python, comparing against None should be done using the "is" operator (instead of the equal operator "=="), as it may leads in some tricky cases to be evaluated as True while False is expected. So this should be changed to:
self.q_ranges is not None
Please change all the occurrences of these (I may have missed some in other files too)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @EveCharbie)
@EveCharbie |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 21 of 21 files at r3, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @EveCharbie)
ce60955
to
8f55d92
Compare
8f55d92
to
3f523d9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 6 of 6 files at r4, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @EveCharbie)
This change is