Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish py3.13 support and move docker to 3.13 #1848

Merged
merged 1 commit into from
Jan 6, 2025
Merged

Finish py3.13 support and move docker to 3.13 #1848

merged 1 commit into from
Jan 6, 2025

Conversation

cooperlees
Copy link
Contributor

  • Update classifiers
  • Add 3.13 to CI
  • Move Dockerfile to use 3.13 by default
  • Add py3.13 to filter plugin filename_name.py

Test:

  • Build docker locally
cooper@cooper-fedora-MJ0J8MTZ:~/repos/bandersnatch$ docker build -t bandersnatch_test --network host .
[+] Building 1.0s (23/23) FINISHED                                                                       docker:default
 => [internal] load build definition from Dockerfile                                                               0.1s
 => => transferring dockerfile: 1.23kB                                                                             0.0s
 => [internal] load metadata for docker.io/library/python:3.13-slim                                                0.4s
 => [internal] load metadata for docker.io/library/python:3.13                                                     0.5s
 => [internal] load .dockerignore                                                                                  0.1s
 => => transferring context: 290B                                                                                  0.0s
 => [base 1/1] FROM docker.io/library/python:3.13@sha256:cea505b81701dd9e46b8dde96eaa8054c4bd2035dbb660edeb7af947  0.0s
 => [stage-2  1/10] FROM docker.io/library/python:3.13-slim@sha256:1127090f9fff0b8e7c3a1367855ef8a3299472d2c9ed12  0.0s
 => [internal] load build context                                                                                  0.1s
 => => transferring context: 36.67kB                                                                               0.0s
 => CACHED [builder 1/6] RUN mkdir /install                                                                        0.0s
 => CACHED [builder 2/6] WORKDIR /install                                                                          0.0s
 => CACHED [builder 3/6] RUN pip install --target="/install" --upgrade pip setuptools wheel                        0.0s
 => CACHED [builder 4/6] ADD requirements_s3.txt /install                                                          0.0s
 => CACHED [builder 5/6] ADD requirements.txt /install                                                             0.0s
 => CACHED [builder 6/6] RUN if [ ! -z "$WITH_S3" ]      ; then      pip install --target="/install"         -r r  0.0s
 => CACHED [stage-2  2/10] COPY --from=builder /install /usr/local/lib/python3.13/site-packages                    0.0s
 => CACHED [stage-2  3/10] RUN mkdir /bandersnatch && mkdir /conf && chmod 777 /conf                               0.0s
 => CACHED [stage-2  4/10] WORKDIR /bandersnatch                                                                   0.0s
 => CACHED [stage-2  5/10] COPY setup.cfg /bandersnatch                                                            0.0s
 => CACHED [stage-2  6/10] COPY setup.py /bandersnatch                                                             0.0s
 => CACHED [stage-2  7/10] COPY README.md /bandersnatch                                                            0.0s
 => CACHED [stage-2  8/10] COPY LICENSE /bandersnatch                                                              0.0s
 => CACHED [stage-2  9/10] COPY src /bandersnatch/src                                                              0.0s
 => CACHED [stage-2 10/10] RUN if [ ! -z "$WITH_S3" ]      ; then      pip --no-cache-dir install /bandersnatch/[  0.0s
 => exporting to image                                                                                             0.0s
 => => exporting layers                                                                                            0.0s
 => => writing image sha256:6e8a0c36d35f211ab9dea942fd3caaeac2d40285800a9c395335dc12c9657e9c                       0.0s
 => => naming to docker.io/library/bandersnatch_test
  • Actions on PR

- Update classifiers
- Add 3.13 to CI
- Move Dockerfile to use 3.13 by default
- Add py3.13 to filter plugin `filename_name.py`

Test:
- Build docker locally
```
cooper@cooper-fedora-MJ0J8MTZ:~/repos/bandersnatch$ docker build -t bandersnatch_test --network host .
[+] Building 1.0s (23/23) FINISHED                                                                       docker:default
 => [internal] load build definition from Dockerfile                                                               0.1s
 => => transferring dockerfile: 1.23kB                                                                             0.0s
 => [internal] load metadata for docker.io/library/python:3.13-slim                                                0.4s
 => [internal] load metadata for docker.io/library/python:3.13                                                     0.5s
 => [internal] load .dockerignore                                                                                  0.1s
 => => transferring context: 290B                                                                                  0.0s
 => [base 1/1] FROM docker.io/library/python:3.13@sha256:cea505b81701dd9e46b8dde96eaa8054c4bd2035dbb660edeb7af947  0.0s
 => [stage-2  1/10] FROM docker.io/library/python:3.13-slim@sha256:1127090f9fff0b8e7c3a1367855ef8a3299472d2c9ed12  0.0s
 => [internal] load build context                                                                                  0.1s
 => => transferring context: 36.67kB                                                                               0.0s
 => CACHED [builder 1/6] RUN mkdir /install                                                                        0.0s
 => CACHED [builder 2/6] WORKDIR /install                                                                          0.0s
 => CACHED [builder 3/6] RUN pip install --target="/install" --upgrade pip setuptools wheel                        0.0s
 => CACHED [builder 4/6] ADD requirements_s3.txt /install                                                          0.0s
 => CACHED [builder 5/6] ADD requirements.txt /install                                                             0.0s
 => CACHED [builder 6/6] RUN if [ ! -z "$WITH_S3" ]      ; then      pip install --target="/install"         -r r  0.0s
 => CACHED [stage-2  2/10] COPY --from=builder /install /usr/local/lib/python3.13/site-packages                    0.0s
 => CACHED [stage-2  3/10] RUN mkdir /bandersnatch && mkdir /conf && chmod 777 /conf                               0.0s
 => CACHED [stage-2  4/10] WORKDIR /bandersnatch                                                                   0.0s
 => CACHED [stage-2  5/10] COPY setup.cfg /bandersnatch                                                            0.0s
 => CACHED [stage-2  6/10] COPY setup.py /bandersnatch                                                             0.0s
 => CACHED [stage-2  7/10] COPY README.md /bandersnatch                                                            0.0s
 => CACHED [stage-2  8/10] COPY LICENSE /bandersnatch                                                              0.0s
 => CACHED [stage-2  9/10] COPY src /bandersnatch/src                                                              0.0s
 => CACHED [stage-2 10/10] RUN if [ ! -z "$WITH_S3" ]      ; then      pip --no-cache-dir install /bandersnatch/[  0.0s
 => exporting to image                                                                                             0.0s
 => => exporting layers                                                                                            0.0s
 => => writing image sha256:6e8a0c36d35f211ab9dea942fd3caaeac2d40285800a9c395335dc12c9657e9c                       0.0s
 => => naming to docker.io/library/bandersnatch_test
```
- Actions on PR
@cooperlees cooperlees added the enhancement New feature or request label Jan 6, 2025
@cooperlees cooperlees merged commit b6e1288 into main Jan 6, 2025
13 checks passed
@cooperlees cooperlees deleted the py3.13 branch January 6, 2025 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant