Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline dependency-versions syntax #2122

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Conversation

joerick
Copy link
Contributor

@joerick joerick commented Jan 5, 2025

To help with #2002, I propose a way to specify dependency version constraints inline, without the extra file. This would eliminate the need for an additional CIBW_PYODIDE_BUILD_VERSION option, while being consistent with our existing version management system.

This would allow setting the pyodide-build version like:

CIBW_DEPENDENCY_VERSIONS_PYODIDE: "packages: pyodide-build==0.29.1"

So far, no implementation yet, just docs for discussion.

@joerick joerick marked this pull request as draft January 5, 2025 14:48
@joerick
Copy link
Contributor Author

joerick commented Jan 27, 2025

Having reviewed #2002 again, I think this would be a useful feature. Specifically, there's a check for compatible versions between pyodide and pyodide-build - if we provide an option for CIBW_PYODIDE_VERSION, and we don't have this, changing pyodide version becomes a bit hassle, because you need to make a constraints file as well.

@joerick joerick force-pushed the dependency-version-inline branch from 1912c7a to 870a1dd Compare January 31, 2025 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant