Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Travis CI tests on ppc64le/s390x #689

Merged
merged 6 commits into from
May 23, 2021

Conversation

mayeut
Copy link
Member

@mayeut mayeut commented May 23, 2021

mayeut added 2 commits May 23, 2021 12:52
This removes allow_failures from the Travis CI s390x job
@mayeut mayeut force-pushed the disable-ppc64le-manylinux-only branch from 4f290e3 to bce6bd2 Compare May 23, 2021 10:52
@mayeut mayeut marked this pull request as ready for review May 23, 2021 10:54
Copy link
Contributor

@joerick joerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Should we update the example configs with dist: focal, too?

@joerick
Copy link
Contributor

joerick commented May 23, 2021

BTW, another idea to skip the test could be something like PYTEST_ADDOPTS='-k "not test_manylinuxXXXX_only"' in the Travis config? I haven't tested that but it might work...? but this is fine too

@mayeut
Copy link
Member Author

mayeut commented May 23, 2021

Should we update the example configs with dist: focal, too?

You're right.
On a side note, I only updated the alternate archs but my recommendation would always be to run the linux axis on the most recent stable distro provided by any CI provider.

@mayeut mayeut requested review from YannickJadoul and joerick May 23, 2021 15:45
Copy link
Contributor

@joerick joerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Contributor

@henryiii henryiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the setting in the config, too.

Copy link
Member

@YannickJadoul YannickJadoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same for me! I'll go ahead and merge this, then :-)

@YannickJadoul YannickJadoul merged commit 0e988e2 into pypa:master May 23, 2021
@mayeut mayeut deleted the disable-ppc64le-manylinux-only branch May 23, 2021 21:46
henryiii pushed a commit to henryiii/cibuildwheel that referenced this pull request May 24, 2021
* Disable manylinux only tests on Travis CI ppc64le

Those tests are taking too much disk space for the Travis CI runner right now.
c.f. https://travis-ci.community/t/running-out-of-disk-space-quota-when-using-docker-on-ppc64le/11634

* Use focal to run aarch64/ppc64le/s390x jobs on Travis CI

This removes allow_failures from the Travis CI s390x job

* Use `focal` distribution for all Travis CI configurations

* Revert "Disable manylinux only tests on Travis CI ppc64le"

This reverts commit d0a09c6.

* Skip test_manylinuxXXXX_only on Travis CI ppc64le

* Add a comment on why test_manylinuxXXXX_only test is skipped
henryiii pushed a commit that referenced this pull request May 24, 2021
* Disable manylinux only tests on Travis CI ppc64le

Those tests are taking too much disk space for the Travis CI runner right now.
c.f. https://travis-ci.community/t/running-out-of-disk-space-quota-when-using-docker-on-ppc64le/11634

* Use focal to run aarch64/ppc64le/s390x jobs on Travis CI

This removes allow_failures from the Travis CI s390x job

* Use `focal` distribution for all Travis CI configurations

* Revert "Disable manylinux only tests on Travis CI ppc64le"

This reverts commit d0a09c6.

* Skip test_manylinuxXXXX_only on Travis CI ppc64le

* Add a comment on why test_manylinuxXXXX_only test is skipped
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants