Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update deprecated option check #700

Merged
merged 3 commits into from
May 29, 2021
Merged

feat: update deprecated option check #700

merged 3 commits into from
May 29, 2021

Conversation

henryiii
Copy link
Contributor

@henryiii henryiii commented May 25, 2021

Dropping the old check, and adding a new one for p2 or p35 in selectors.

Not sure if this is a "fix", "feat", or "chore". 😜

@henryiii henryiii mentioned this pull request May 25, 2021
12 tasks
@henryiii henryiii marked this pull request as draft May 25, 2021 23:30
@henryiii henryiii force-pushed the henryiii/feat/depsel branch from e14707e to b24757d Compare May 26, 2021 02:48
@henryiii henryiii marked this pull request as ready for review May 26, 2021 04:25
@henryiii henryiii changed the title fix: update deprecated option check feat: update deprecated option check May 26, 2021
@mayeut mayeut force-pushed the henryiii/feat/depsel branch from a18a558 to 0b61a1d Compare May 27, 2021 10:23
Copy link
Member

@mayeut mayeut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@henryiii henryiii force-pushed the henryiii/feat/depsel branch from 0b61a1d to 4205d8b Compare May 28, 2021 22:36
@mayeut mayeut merged commit 768ecab into main May 29, 2021
@henryiii henryiii deleted the henryiii/feat/depsel branch May 12, 2024 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants