Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generated setup.py use setuptools when available #333

Closed
wants to merge 1 commit into from
Closed

Generated setup.py use setuptools when available #333

wants to merge 1 commit into from

Conversation

kitterma
Copy link
Contributor

@kitterma kitterma commented Apr 7, 2020

It would be nice if the generated setup.py would support using setuptools. The generated setup.py already includes setuptools specific options, so I think it would make sense for it to use setuptools when it available (example from pep517):

Unknown distribution option: 'install_requires'
Unknown distribution option: 'extras_require'

This PR changes the generated setup.py to use setuptools when available, but fall back to distutils (current behavior) if it is not.

@takluyver
Copy link
Member

Thanks, but this is deliberate - the setup.py is meant as a temporary shim so older versions of pip can handle the sdist. I want to discourage running it directly. Pip ensures that setuptools is loaded even if the script doesn't explicitly specify it, and works around some of the problems that setuptools otherwise causes.

I'll add a comment to this effect.

@takluyver takluyver closed this Apr 7, 2020
@takluyver
Copy link
Member

Added a comment in 8ed3317

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants