Use RequirementsFileParserError instead of RecursionError

pypa · Aug 18, 2024 · 7698545 · 7698545
1 parent 15b3acb
commit 7698545
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/src/pip/_internal/req/req_file.py b/src/pip/_internal/req/req_file.py
@@ -371,7 +371,7 @@ def _parse_and_recurse(
                         if initial_file is not None
                         else ""
                     )
-                    raise RecursionError(
+                    raise RequirementsFileParseError(
                         f"{req_path} recursively references itself in {filename} {tail}"
                     )
                 # Keeping a track where was each file first included in

diff --git a/tests/unit/test_req_file.py b/tests/unit/test_req_file.py
@@ -9,7 +9,6 @@
 
 import pytest
 
-import pip._internal.exceptions
 import pip._internal.req.req_file  # this will be monkeypatched
 from pip._internal.exceptions import InstallationError, RequirementsFileParseError
 from pip._internal.index.package_finder import PackageFinder
@@ -364,7 +363,7 @@ def test_recursive_requirements_file(
 
         # When the passed requirements file recursively references itself
         with pytest.raises(
-            RecursionError,
+            RequirementsFileParseError,
             match=(
                 f"{path_to_string(req_files[0])} recursively references itself"
                 f" in {path_to_string(req_files[req_file_count - 1])}"
@@ -378,7 +377,7 @@ def test_recursive_requirements_file(
             f"-r {req_files[req_file_count - 2].name}"
         )
         with pytest.raises(
-            RecursionError,
+            RequirementsFileParseError,
             match=(
                 f"{path_to_string(req_files[req_file_count - 2])} recursively"
                 " references itself in"
@@ -401,7 +400,7 @@ def test_recursive_relative_requirements_file(
         level_2_req_file.write_text("-r ../../root.txt")
 
         with pytest.raises(
-            RecursionError,
+            RequirementsFileParseError,
             match=(
                 f"{path_to_string(root_req_file)} recursively references itself in"
                 f" {path_to_string(level_2_req_file)}"